Detour installation script - #96
Merged
Merged
Conversation
goagain
marked this pull request as ready for review
June 9, 2022 01:35
Reilly Tucker Siemens (reillysiemens)
approved these changes
Jun 9, 2022
Contributor
|
I have tested on Windows10. goagain can you also do a test on Win Server, just to really check that string interpolation works in PowerShell 4/5. My Trust in PowerShell across all it's versions is gone. |
Contributor
Author
|
Kyle W. Rader (@kyle-rader), I Tested on Windows 2012 and it works on PowerShell 4.0 |
Kyle W. Rader (kyle-rader)
approved these changes
Jun 9, 2022
goagain
added
security
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changing installation is dangerous because it is out of version control. We made mistakes in #93 and #95.
Detouring the installation script to release version can guarantee our customers always use a release version and avoid this problem.
Questions
The cost is we cannot deliver the installation script as fast as we can. But if our versions are becoming more and more stable, I think that cost is worthy.