Pass through verify flag and fix scopes default value #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Jun 17, 2019
ghost
commented
- Pass through verify flag
- change default value from None to [] as None leads to a crash further downstream
rayluo
requested changes
Jun 17, 2019
ghost
force-pushed
the
pass_through_verify
branch
from
238adf8 to
2791b62
Compare
Although not strictly enforced (by pylint) in this repo, we don't want to noticeably exceed that limit. https://www.python.org/dev/peps/pep-0008/#maximum-line-length
rayluo
approved these changes
Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.