Hotfix minor gui bugs #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem:
The GUI defaulted to the info log tab in the dialog box.
The solution:
The rover_gui_plugin.ui configuration file was edited so that
the correct tab was set to the default when loading the GUI.
The problem:
A label in the GUI was set to "Panning", which was too vague.
The solution:
The label was edited to be "Panning and Zoom" so that users of the
GUI would no that they also had control over manual zooming in the
map frame.
…tip)
The problem:
Hovering over the "run visualization on build" check box displayed
an incorrect tool tip for a different element of the GUI.
The solution:
The tooltip was removed.
The problem:
The GUI defaulted to the info log tab in the dialog box.
The solution:
In addition to previous edits to rover_gui_plugin.ui, we now also
strictly enforce this tab as the default directly in the code
when the RQT rover GUI is launched.
This was referenced Oct 27, 2017
kristiana-rendon
previously requested changes
Oct 31, 2017
Contributor
kristiana-rendon
left a comment
kristiana-rendon
left a comment
There was a problem hiding this comment.
Working
1.) GUI defaults to diagnostics tab
2.) Panning and Zoom is correctly displayed
Not Working
1.) When hovering over "Start Visualization on Build" checkbox, no tip shows at all. There is a tiny black rectangle that appears under the checkbox.
Additional Comments
None
gmfricke
approved these changes
Nov 2, 2017
Contributor
gmfricke
left a comment
gmfricke
left a comment
There was a problem hiding this comment.
The empty tooltip is a minor issue that can be fixed in a separate pull request.
gmfricke
dismissed
kristiana-rendon’s stale review
The only negative was an empty tooltip. This should be fixed in a future pull request but is not enough to prevent acceptance of this pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses several minor issues at once:
issue #85
issue #70
issue #54