feat(auth): apply require_role guard to fee updates - #594
Merged
p3ris0n merged 5 commits intoJul 28, 2026
Conversation
Add require_fee_admin guard and protect fee configuration endpoints with Role::Admin authorization. Closes BCPathway#444 Co-authored-by: Cursor <cursoragent@cursor.com>
|
@mysterio123865 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Co-authored-by: Cursor <cursoragent@cursor.com>
Use u32 for fee exemption type, rename internal storage helper to avoid duplicate symbol, and fix test assertions for Soroban client API. Co-authored-by: Cursor <cursoragent@cursor.com>
…ee-updates-444 Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # contracts/token/src/test.rs
Contributor
|
@mysterio123865 give a detailed pr |
…ee-updates-444 Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # contracts/admin/src/lib.rs
Contributor
Author
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add require_fee_admin guard and protect fee configuration endpoints with Role::Admin authorization.
Closes #444
Summary
This PR updates the authorization model for fee configuration by replacing direct administrator checks with the shared
require_roleguard. The change centralizes access control, aligns fee updates with the project's role-based authorization framework, and ensures only authorized accounts can modify fee settings.What Changed
require_adminauthorization checks for fee update operations with the sharedrequire_roleguard.Tests
Documentation
What does this PR do?
Type of change
Checklist
pre-commit run --all-fileslocally and it passedBreaking changes?
Related issues
Closes #