Skip to content

feat: 팀원 모집 파일 업로드 도메인 추가 - #2334

Merged
taejinn merged 1 commit into
developfrom
feat/2333-team-recruitment-upload-domain
Aug 27, 2026
Merged

feat: 팀원 모집 파일 업로드 도메인 추가#2334
taejinn merged 1 commit into
developfrom
feat/2333-team-recruitment-upload-domain

Conversation

@taejinn

@taejinn taejinn commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

🔍 개요

  • 기존 공용 파일 업로드 API에서 팀원 모집 도메인을 지원합니다.

🚀 주요 변경 내용

  • ImageUploadDomainTEAM_RECRUITMENT를 추가했습니다.
  • 공용 URL 생성, 단건 및 다중 업로드 API의 Swagger 지원 목록에 team_recruitment를 추가했습니다.
  • team_recruitment 경로 파라미터 변환 테스트를 추가했습니다.

💬 참고 사항

  • 팀원 모집 클라이언트는 POST /team_recruitment/upload/url을 사용합니다.
  • 검증: ./gradlew clean test

✅ Checklist (완료 조건)

  • 코드 스타일 가이드 준수
  • 테스트 코드 포함됨
  • Reviewers / Assignees / Labels 지정 완료
  • 보안 및 민감 정보 검증 (API 키, 환경 변수, 개인정보 등)

Summary by CodeRabbit

  • New Features

    • Added support for team_recruitment as an image upload domain.
    • Updated upload API documentation to list the new supported domain.
  • Tests

    • Added coverage verifying correct recognition of the new image upload domain.

@taejinn taejinn added 기능 새로운 기능을 개발합니다. 공통 백엔드 공통으로 작업할 이슈입니다. labels Aug 27, 2026
@taejinn taejinn self-assigned this Aug 27, 2026
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3c40909a-335c-4412-be22-7217375343d4

📥 Commits

Reviewing files that changed from the base of the PR and between df97a72 and 69718b2.

📒 Files selected for processing (3)
  • src/main/java/in/koreatech/koin/domain/upload/controller/UploadApi.java
  • src/main/java/in/koreatech/koin/infrastructure/s3/model/ImageUploadDomain.java
  • src/test/java/in/koreatech/koin/infrastructure/s3/convertor/ImageUploadDomainEnumConverterTest.java

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The shared upload domain now supports TEAM_RECRUITMENT. Its converter test verifies the team_recruitment value. Swagger descriptions for all shared upload endpoints list the new domain.

Changes

Team recruitment upload support

Layer / File(s) Summary
Upload domain support
src/main/java/in/koreatech/koin/infrastructure/s3/model/ImageUploadDomain.java, src/test/java/in/koreatech/koin/infrastructure/s3/convertor/ImageUploadDomainEnumConverterTest.java
Adds TEAM_RECRUITMENT and verifies conversion from team_recruitment.
Upload API documentation
src/main/java/in/koreatech/koin/domain/upload/controller/UploadApi.java
Adds team_recruitment to the Swagger descriptions for presigned URL, single-file, and multi-file upload endpoints.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: 🟡 Moderate · up to 69718

The change exposes team-recruitment files through anonymous shared upload routes, including publicly readable direct uploads, without binding files to a user or team. Recruitment files could therefore be uploaded or accessed without the intended ownership controls; merge requires this security behavior to be addressed or explicitly accepted by the owner.

Suggested reviewers: dh2906, soundbar91, dhkimgit, janoogwan, kih1015

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 3 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed 변경 사항은 공용 업로드 도메인에 TEAM_RECRUITMENT를 추가하고, Swagger 지원 목록을 갱신하며, team_recruitment 변환 테스트를 추가합니다. 이는 연결 이슈 #2333의 요구 사항을 충족합니다.
Out of Scope Changes check ✅ Passed 모든 변경 사항은 연결 이슈 #2333의 공용 파일 업로드 도메인 추가 범위에 포함됩니다. 팀원 모집 전용 업로드 API와 채팅 이미지 메시지 기능은 추가되지 않았습니다.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding the team recruitment file upload domain.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/2333-team-recruitment-upload-domain

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Unit Test Results

787 tests  +1   784 ✔️ +1   1m 27s ⏱️ +3s
190 suites +1       3 💤 ±0 
190 files   +1       0 ±0 

Results for commit 69718b2. ± Comparison against base commit df97a72.

@dnjswldnd-3513 dnjswldnd-3513 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!

@taejinn
taejinn merged commit 17b8f8a into develop Aug 27, 2026
11 checks passed
@taejinn
taejinn deleted the feat/2333-team-recruitment-upload-domain branch August 27, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

공통 백엔드 공통으로 작업할 이슈입니다. 기능 새로운 기능을 개발합니다.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[공통] 팀원 모집 파일 업로드 도메인 추가

2 participants