Skip to content

docs: 팀원 모집 역할 표시 순서 fallback 을 Swagger 설명에 명시 - #2358

Merged
insik03 merged 1 commit into
developfrom
docs/team-recruitment-display-order-note
Aug 30, 2026
Merged

docs: 팀원 모집 역할 표시 순서 fallback 을 Swagger 설명에 명시#2358
insik03 merged 1 commit into
developfrom
docs/team-recruitment-display-order-note

Conversation

@insik03

@insik03 insik03 commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

🔍 개요

  • fix: 팀원 모집 게시글 명세 반영 및 요청 검증 보강 #2357 의 CodeRabbit 리뷰에서 지적된 항목을 반영합니다. 대응 커밋이 머지 시점을 놓쳐 포함되지 못해 별도로 올립니다.
  • 모집글 수정 API 의 Swagger 설명이 새 역할 배치 규칙을 "기존 역할 뒤에 추가"로만 적고 있어, 실제 구현에 있는 예외 경로가 문서에 없습니다.

🚀 주요 변경 내용

  • TeamRecruitmentApi 의 모집글 수정 @Operation 설명에 display_order fallback 경로를 2줄 추가했습니다. 문서 문자열만 바뀌며 동작 변경은 없습니다.

💬 참고 사항


✅ Checklist (완료 조건)

  • 코드 스타일 가이드 준수
  • 테스트 코드 포함됨 (문서 문자열 변경이라 해당 없음)
  • Reviewers / Assignees / Labels 지정 완료 (Reviewers: @taejinn, @dnjswldnd-3513)
  • 보안 및 민감 정보 검증 (API 키, 환경 변수, 개인정보 등)

- 표시 순서는 1~5 만 사용할 수 있어, 낮은 순서가 비어 있고 뒤에 남은 자리가 없으면
  새 역할이 앞 순서를 사용한다. 이 경로가 설명에 없어 실제 동작과 계약이 달랐다.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings August 30, 2026 06:20
@insik03 insik03 self-assigned this Aug 30, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 19 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ed56629e-74bb-4ad7-8262-3eea6e5ff392

📥 Commits

Reviewing files that changed from the base of the PR and between 74c30b5 and e21e759.

📒 Files selected for processing (1)
  • src/main/java/in/koreatech/koin/domain/team/recruitment/controller/TeamRecruitmentApi.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the 문서 문서화와 관련된 이슈입니다. label Aug 30, 2026
@github-actions
github-actions Bot requested review from ImTotem and JanooGwan August 30, 2026 06:20
@github-actions

Copy link
Copy Markdown

Unit Test Results

1 024 tests   1 021 ✔️  1m 51s ⏱️
   239 suites         3 💤
   239 files           0

Results for commit e21e759.

dnjswldnd-3513

This comment was marked as resolved.

@dnjswldnd-3513 dnjswldnd-3513 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드 확인했습니다!

@insik03
insik03 merged commit 3e133e8 into develop Aug 30, 2026
7 checks passed
@insik03
insik03 deleted the docs/team-recruitment-display-order-note branch August 30, 2026 06:39
@taejinn taejinn mentioned this pull request Sep 1, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

문서 문서화와 관련된 이슈입니다.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants