Skip to content

feat: 팀원 모집 알림 개별 삭제 API 구현 - #2363

Merged
insik03 merged 1 commit into
developfrom
feat/team-recruitment-notification-delete
Aug 30, 2026
Merged

feat: 팀원 모집 알림 개별 삭제 API 구현#2363
insik03 merged 1 commit into
developfrom
feat/team-recruitment-notification-delete

Conversation

@insik03

@insik03 insik03 commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

🔍 개요

  • 팀원 모집 알림에 개별 삭제 API 를 추가합니다. 기존에는 전체 삭제만 있어 알림을 하나씩 정리할 수단이 없었습니다.

🚀 주요 변경 내용

  • DELETE /team-recruitments/notifications/{notificationId} 를 추가했습니다. 응답은 기존 개별 읽음 처리와 동일하게 204 No Content 입니다.
  • 본인에게 온 알림만 삭제하도록 findByIdAndRecipient_Id 로 조회하고, 없으면 TEAM_RECRUITMENT_NOTIFICATION_NOT_FOUND (404) 를 반환합니다. 남의 알림 ID 를 넣어도 404 라 존재 여부가 드러나지 않습니다.
  • 삭제는 기존 전체 삭제와 같은 소프트 삭제입니다. is_deletedtrue 가 되어 목록 조회와 미읽음 수 집계에서 제외됩니다.

💬 참고 사항

로컬에서 확인한 결과입니다.

확인 항목 결과
단위 테스트 (정상 삭제 / 존재하지 않는 알림 404) 통과
Swagger 노출 DELETE /team-recruitments/notifications/{notificationId} — 204, 404, 401, 403
미인증 실호출 401

✅ Checklist (완료 조건)

  • 코드 스타일 가이드 준수
  • 테스트 코드 포함됨
  • Reviewers / Assignees / Labels 지정 완료 (Reviewers: @taejinn, @dnjswldnd-3513)
  • 보안 및 민감 정보 검증 (API 키, 환경 변수, 개인정보 등)

Copilot AI lite review requested due to automatic review settings August 30, 2026 07:54
@insik03 insik03 self-assigned this Aug 30, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 34 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 054e052d-c0ca-46d5-89a9-746db4b574c7

📥 Commits

Reviewing files that changed from the base of the PR and between 4df746c and bf0b0cd.

📒 Files selected for processing (4)
  • src/main/java/in/koreatech/koin/domain/teamrecruitment/controller/TeamRecruitmentNotificationApi.java
  • src/main/java/in/koreatech/koin/domain/teamrecruitment/controller/TeamRecruitmentNotificationController.java
  • src/main/java/in/koreatech/koin/domain/teamrecruitment/service/TeamRecruitmentNotificationService.java
  • src/test/java/in/koreatech/koin/unit/domain/teamrecruitment/service/TeamRecruitmentNotificationServiceTest.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the 기능 새로운 기능을 개발합니다. label Aug 30, 2026
@github-actions
github-actions Bot requested a review from JanooGwan August 30, 2026 07:54

@dnjswldnd-3513 dnjswldnd-3513 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드 확인했습니다!

@insik03
insik03 removed the request for review from JanooGwan August 30, 2026 07:59
@github-actions

Copy link
Copy Markdown

Unit Test Results

1 026 tests   1 023 ✔️  2m 10s ⏱️
   239 suites         3 💤
   239 files           0

Results for commit bf0b0cd.

@insik03
insik03 merged commit 90d730a into develop Aug 30, 2026
7 checks passed
@insik03
insik03 deleted the feat/team-recruitment-notification-delete branch August 30, 2026 08:36
@taejinn taejinn mentioned this pull request Sep 1, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

기능 새로운 기능을 개발합니다.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[공통] 팀원 모집 알림 개별 삭제 API 구현

3 participants