feat: 팀원 모집 알림 개별 삭제 API 구현 - #2363
Merged
Merged
Conversation
|
Warning Review limit reachedNext included review available in 34 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 개요
🚀 주요 변경 내용
DELETE /team-recruitments/notifications/{notificationId}를 추가했습니다. 응답은 기존 개별 읽음 처리와 동일하게204 No Content입니다.findByIdAndRecipient_Id로 조회하고, 없으면TEAM_RECRUITMENT_NOTIFICATION_NOT_FOUND(404) 를 반환합니다. 남의 알림 ID 를 넣어도 404 라 존재 여부가 드러나지 않습니다.is_deleted가true가 되어 목록 조회와 미읽음 수 집계에서 제외됩니다.💬 참고 사항
delete()와findByIdAndRecipient_Id가 이미 있어 그대로 사용합니다.DELETE /team-recruitments/notifications)와 경로가 겹치지 않습니다.로컬에서 확인한 결과입니다.
DELETE /team-recruitments/notifications/{notificationId}— 204, 404, 401, 403✅ Checklist (완료 조건)