Fixed importing concurrent#249
Merged
Merged
Conversation
Felix-Mallinder
requested changes
Sep 12, 2024
Contributor
Author
|
@Tom-Kingstone to confirm, the following actions are now queued:
|
Contributor
Author
|
@Tom-Kingstone to confirm, the following actions are now queued:
|
Felix-Mallinder
approved these changes
Sep 12, 2024
Felix-Mallinder
left a comment
There was a problem hiding this comment.
Tested. Can confirm success as solar.png is created in the same folder as gh test script.
Contributor
Author
|
@Tom-Kingstone to confirm, the following actions are now queued:
|
jamesramsden-bh
approved these changes
Sep 12, 2024
Contributor
jamesramsden-bh
left a comment
There was a problem hiding this comment.
solar.png created successfully. Code reviewed, reference change is fine.
Contributor
|
@BHoMBot check ready-to-merge |
|
@jamesramsden-bh to confirm, the following actions are now queued:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
Issues addressed by this PR
Closes #248
As in issue
Test files
The LBT beta test script will be the test - ensure that the
Solar.pngfile is created in the same directory as the grasshopper script.Changelog
Additional comments