Skip to content

Conversation

@BHoMBot
Copy link
Member

@BHoMBot BHoMBot commented Sep 27, 2022

Remove 5.3 Previous Version Attributes

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Sep 27, 2022
@FraserGreenroyd FraserGreenroyd self-requested a review September 27, 2022 13:26
@bhombot-ci
Copy link

bhombot-ci bot commented Sep 27, 2022

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine

@FraserGreenroyd
Copy link

FraserGreenroyd commented Sep 27, 2022

@BHoMBot check code-compliance
@BHoMBot check documentation-compliance
@BHoMBot check dataset-compliance
@BHoMBot check project-compliance
@BHoMBot check copyright-compliance
@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 27, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check dataset-compliance
  • check project-compliance
  • check copyright-compliance
  • check core
  • check null-handling
  • check serialisation

There are 26 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 27, 2022

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine

Copy link

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving from a DevOps perspective after code review.

@FraserGreenroyd
Copy link

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 27, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 12 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit 7b04745 into main Sep 27, 2022
@FraserGreenroyd FraserGreenroyd deleted the BHoM-RemovePreviousVersion53 branch September 27, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:compliance Non-conforming to code guidelines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants