Skip to content

Conversation

@tg359
Copy link
Contributor

@tg359 tg359 commented Nov 29, 2022

Issues addressed by this PR

Closes #206

Many things changed in source PR, though only minor changes to objects between versions requiring conversion here.

Test files

Changelog

  • Added Converter methods for LBT_Toolkit Shelter and Typology objects

Additional comments

Do not merge LadybugTools_Toolkit branch - it should be deleted once this PR gets tested & approved!

@tg359 tg359 added severity:medium Slows progress, but workaround is possible size:S Measured in minutes labels Nov 29, 2022
@tg359 tg359 self-assigned this Nov 29, 2022
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 29, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 29, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 30, 2022

@tg359 just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @jamesramsden-bh on LadybugTools_Toolkit

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 30, 2022

@tg359 just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @jamesramsden-bh on LadybugTools_Toolkit

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 30, 2022

@tg359 just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @tg359 on LadybugTools_Toolkit

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 30, 2022

@tg359 just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @tg359 on LadybugTools_Toolkit

@jamesramsden-bh
Copy link

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 1, 2022

@jamesramsden-bh to confirm, the following actions are now queued:

  • check copyright-compliance

There are 2 requests in the queue ahead of you.

@jamesramsden-bh
Copy link

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 1, 2022

@jamesramsden-bh to confirm, the following actions are now queued:

  • check core

@jamesramsden-bh jamesramsden-bh added type:compliance Non-conforming to code guidelines type:feature New capability or enhancement and removed type:compliance Non-conforming to code guidelines labels Dec 1, 2022
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Versioning is happy, I'm happy. @jamesramsden-bh is happy with the dependent PR so all good to merge.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 1, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 5 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit dc86599 into main Dec 1, 2022
@FraserGreenroyd FraserGreenroyd deleted the LBT_Toolkit-#66-AnalyticsRefactorAndExternalComfortProcessing branch December 1, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

severity:medium Slows progress, but workaround is possible size:S Measured in minutes type:feature New capability or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Versioning for LadybugTools_Toolkit

4 participants