ModuleLoadTest: drop dbghelp.dll from expected Win32 boot modules#1696
Merged
Conversation
bx commit 3ea49f9 ("Lazy load debug help once it's needed to resolve
callstack", BabylonJS#383) moved the dlopen("dbghelp.dll") call out of the
file-scope static's constructor into a lazy init() invoked on the
first writeCallstack call.
That commit is in the bx submodule of BabylonJS/bgfx.cmake e5f3f31,
which is BabylonNative's current GIT_TAG pin (root CMakeLists.txt).
So a fresh BN build no longer pulls dbghelp.dll into the process on
startup. Verified locally with a fresh RelWithDebInfo configure +
build + run; dbghelp.dll is not in the boot delta.
Resolves @bkaradzic-microsoft's review comment on BabylonJS#1666 (L70).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes dbghelp.dll from the Win32 boot module allow-list in ModuleLoadTest since the pinned bgfx/bx version now lazy-loads it instead of loading at static-init time.
Changes:
- Drop
dbghelp.dllentry and its bgfx-blocked TODO fromGetExpectedBootModules().
bkaradzic-microsoft
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
bx commit
3ea49f9("Lazy load debug help once it's needed to resolve callstack", #383) moved thedlopen("dbghelp.dll")call out of the file-scope static's constructor into a lazyinit()invoked on the firstwriteCallstackcall.That commit is in the bx submodule of BabylonJS/bgfx.cmake
e5f3f31, which is BabylonNative's currentGIT_TAGpin (rootCMakeLists.txt). So a fresh BN build no longer pullsdbghelp.dllinto the process on startup.Change
Drop
dbghelp.dllfromGetExpectedBootModules()inApps/ModuleLoadTest/Source/App.Win32.cpp, plus the TODO comment that flagged it as bgfx-blocked. Resolves @bkaradzic-microsoft's review comment on #1666 (L70).Verification
Local RelWithDebInfo build + run (Win11 x64, D3D11 + Chakra):
_deps/bgfx.cmake-srcto force re-fetch at the pinned SHA).ModuleLoadTestRelWithDebInfo.PASS.dbghelp.dllis NOT in the boot delta. (imagehlp.dllstill is -- different DLL, image loader.)[Created by Copilot on behalf of @bghgary]