Suppress x/y position events until after pointer down event#383
Merged
Conversation
Alex-MSFT
approved these changes
Aug 28, 2020
bghgary
added a commit
that referenced
this pull request
May 15, 2026
) ## Context bx commit `3ea49f9` ("Lazy load debug help once it's needed to resolve callstack", #383) moved the `dlopen("dbghelp.dll")` call out of the file-scope static's constructor into a lazy `init()` invoked on the first `writeCallstack` call. That commit is in the bx submodule of BabylonJS/bgfx.cmake `e5f3f31`, which is BabylonNative's current `GIT_TAG` pin (root `CMakeLists.txt`). So a fresh BN build no longer pulls `dbghelp.dll` into the process on startup. ## Change Drop `dbghelp.dll` from `GetExpectedBootModules()` in `Apps/ModuleLoadTest/Source/App.Win32.cpp`, plus the TODO comment that flagged it as bgfx-blocked. Resolves @bkaradzic-microsoft's review comment on #1666 (L70). ## Verification Local RelWithDebInfo build + run (Win11 x64, D3D11 + Chakra): - Reconfigured CMake (deleted stale `_deps/bgfx.cmake-src` to force re-fetch at the pinned SHA). - Built `ModuleLoadTest` RelWithDebInfo. - Ran the test; verdict `PASS`. `dbghelp.dll` is NOT in the boot delta. (`imagehlp.dll` still is -- different DLL, image loader.) [Created by Copilot on behalf of @bghgary] Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It doesn't make sense to receive touch move events before touch down, but the touch position does need to be recorded before the touch start (logical) event is raised, so that an event handler can query the touch position. This change fixes this behavior.