Android JS Engine selection#193
Merged
CedricGuillemet merged 17 commits intoMar 31, 2020
Merged
Conversation
android pipelines for v8 and JSC
Closed
9 tasks
…nto androidJSEngine
removed unused napi include for android
syntheticmagus
approved these changes
Mar 30, 2020
| cp -r x86_64 Apps/Playground/Android/app/src/main/jniLibs | ||
| displayName: 'Install V8 npm' | ||
| cd Apps/Playground/Android | ||
| npm install |
Contributor
There was a problem hiding this comment.
nit: Is it possible/advisable to get Gradle to do this part, too?
Collaborator
Author
There was a problem hiding this comment.
I tried without success to do it with gradle using shell command. No idea why. I'm adding an issue: #197
bghgary
approved these changes
Mar 30, 2020
| @@ -0,0 +1,18 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
update .gitignore to ignore node_modules?
Contributor
There was a problem hiding this comment.
also remove Dependenceis/v8 from root .gitignore
Comment on lines
+27
to
+31
| if (${ANDROID_JSENGINE_LIBNAME} STREQUAL "jsc") | ||
| set(NAPI_JAVASCRIPT_ENGINE "JavaScriptCore" CACHE STRING "JavaScript engine for N-API.") | ||
| else() | ||
| set(NAPI_JAVASCRIPT_ENGINE "V8" CACHE STRING "JavaScript engine for N-API.") | ||
| endif() |
Contributor
There was a problem hiding this comment.
nit: might be better to have an else case that throws an error if the libname is not jsc or v8android.
bghgary
added a commit
to bghgary/BabylonNative
that referenced
this pull request
May 22, 2026
Update playground snippet versions to match BJS config where the code is unchanged (no visual diff, no new reference images needed): - Solid particle system: #WCDZS#92 -> BabylonJS#531 (v2 snippet format, same code) - Volumetric Light Scattering + Morph Targets: #5E318S#5 -> BabylonJS#7 (same code) - wgsl-in-shadermaterial: #8RU8Q3#157 -> BabylonJS#193 (same code) The latter two are excludeFromAutomaticTesting so no CI impact. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm installation of JS engine
V8/JSC switch in Gradle
android pipelines for v8 and JSC
build instructions update in an upcoming PR