Initial ARCore integration - #203
Merged
Merged
Conversation
bghgary
reviewed
Apr 3, 2020
| throw std::runtime_error("Failed to get Java VM"); | ||
| } | ||
|
|
||
| // TODO: This should be cleaned up via env->DeleteGlobalRef |
Contributor
There was a problem hiding this comment.
should we fix this before merge?
Member
Author
There was a problem hiding this comment.
My vote is no. I want to stop having to merge cmakelists.txt files :)
Contributor
There was a problem hiding this comment.
Okay, maybe we can file an issue on it.
Comment on lines
+14
to
+16
| # -------------------------------- GSL ----------------------------------- | ||
| # Dependencies: none | ||
| add_subdirectory(arcana.cpp/Source/Submodules/GSL) |
Member
Author
There was a problem hiding this comment.
I'm using gsl::finally in xr.cpp to revert OpenGL state changes I make since we are taking over the gl context every frame (sharing it with Babylon rendering). Ideally we would use our own context that wraps the context used by Babylon rendering, but I never was able to get this to work.
Contributor
There was a problem hiding this comment.
Okay. I'm a bit concerned about reaching into a dependency's dependency. Not sure what the implications are.
bghgary
reviewed
Apr 3, 2020
bghgary
approved these changes
Apr 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds initial support for XR on Android via ARCore.
This all provides initial basic functionality, but there are a bunch of things that still need to be done: