thread suspended when minimized - #32
Merged
Merged
Conversation
syntheticmagus
left a comment
syntheticmagus
left a comment
Contributor
There was a problem hiding this comment.
Was Win32/App.cpp changed? GitHub seems to confused about showing that file for some reason, not sure if I should dig into it further.
Collaborator
Author
|
Nop! I don't know why it switched to binary |
Contributor
|
In reply to the Win32/App.cpp conversation (I can't seem to reply to that directly for some reason), if there are no intentional changes to the file, can you revert whatever Git thinks happened to it? (I think there probably should be changes, but they don't need to be a part of this PR. If we want to properly do suspend/resume in both Win32 and UWP, we can just open an issue to do that in another check-in.) |
…nto ThreadSuspend # Conflicts: # .gitattributes # TestApp/Source/Win32/App.cpp
syntheticmagus
approved these changes
Sep 5, 2019
bghgary
approved these changes
Sep 5, 2019
Merged
CedricGuillemet
added a commit
to CedricGuillemet/BabylonNative
that referenced
this pull request
Sep 2, 2026
0c991337a1 Add pluggable URL scheme resolver (e.g. blob:) to UrlRequest (BabylonJS#37) 425c9f1080 Win32: surface the real error when opening a URL fails (BabylonJS#36) 5683cc4d2f Make Abort() interrupt the libcurl and NSURLSession transports (BabylonJS#34) 80293c0e5a Fix macOS CI: move to Xcode 26.4 on the macos-26 runner ed1a9fdcfa Simplify CI workflows: drop redundant Linux compiler env and macOS build target a5a67c951e Add GitHub Actions CI (Win32, macOS, Linux) (BabylonJS#32) git-subtree-dir: Dependencies/UrlLib git-subtree-split: 0c991337a1160ba7a2d062bf8e342d0a66f48dc9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0% CPU/GPU usage when minimized