-
Notifications
You must be signed in to change notification settings - Fork 161
Image decoding/encoding #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
CedricGuillemet
merged 6 commits into
BabylonJS:master
from
CedricGuillemet:imageEncodingDecoding
Oct 28, 2019
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3d4cdde
Image decoding/encoding
CedricGuillemet 6c1df49
removed empty lines
CedricGuillemet 76025eb
missing JSC function for typed array
CedricGuillemet 0615b3b
moved test script for image codec into its own file
CedricGuillemet 9545473
Merge branch 'master' of https://github.com/BabylonJS/BabylonNative i…
CedricGuillemet f2e2c7f
PR feeedback
CedricGuillemet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| function DecodeEncodeImage(url) | ||
| { | ||
| let onLoadFileError = function(request, exception) { | ||
| console.log("Failed to retrieve " + url + ".", exception); | ||
| }; | ||
| var onload = function(data, responseURL) { | ||
| if (typeof (data) === "string") { | ||
| throw new Error("Decode Image from string data not yet implemented."); | ||
| } | ||
| var image = engine._native.decodeImage(data); | ||
| var imageData = engine._native.getImageData(image); | ||
| console.log("Image data length is " + imageData.length); | ||
| var encoded = engine._native.encodeImage(image); | ||
| console.log("Encoded Image data length is " + encoded.length); | ||
| } | ||
| BABYLON.Tools.LoadFile(url, onload, undefined, undefined, /*useArrayBuffer*/true, onLoadFileError); | ||
| } | ||
|
|
||
| var engine = new BABYLON.NativeEngine(); | ||
|
|
||
| DecodeEncodeImage("https://github.com/BabylonJS/Babylon.js/raw/master/tests/validation/ReferenceImages/Billboard.png"); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you replace this struct with just a
usingto a unique_ptr with a custom deleter?https://stackoverflow.com/questions/19053351/how-do-i-use-a-custom-deleter-with-a-stdunique-ptr-member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea but I didn't manage to do it properly. I ended up having another struct with an operator for deleter. Merging with the ImageData struct for now. If you have an implementation with a custom deleter, I'd be curious to take a look at it :)