Reorganize build dependencies and improve encapsulation#8
Merged
Conversation
Contributor
bghgary
commented
Jun 20, 2019
bghgary
commented
- N-API is now in its own folder with a babylon::Env class that replaces ScriptHost
- N-API now brings in V8 or Chakra depending on the build option
- Build fixes (e.g. scripts now show up in the VS solution and update correctly when modified)
- A bunch of files moved around.
syntheticmagus
approved these changes
Jun 20, 2019
| Runtime::Runtime(std::unique_ptr<RuntimeImpl> impl) | ||
| : m_impl{ std::move(impl) } | ||
| {} | ||
| : m_impl(std::move(impl)) |
Contributor
There was a problem hiding this comment.
nit: I think we use the initializer list syntax instead of the parentheses syntax in most places. Is this one different intentionally?
Contributor
Author
There was a problem hiding this comment.
nope, probably accidentally changed it when i moved things around a few times.
| m_cancelSource.cancel(); | ||
| m_thread.join(); | ||
|
|
||
| m_dispatcher.clear(); // TODO: fix arcana instead of doing this |
Contributor
There was a problem hiding this comment.
Do we remember what happens if we don't do this? If so, should we open an issue on Arcana.cpp?
Contributor
Author
There was a problem hiding this comment.
I don't remember exactly, but I think it should be obvious if we remove the line. Definitely file an issue, arguably in both repos.
Merged
CedricGuillemet
added a commit
that referenced
this pull request
Jun 16, 2021
* GitHub action (#6) * nightly github action * syntax error * more * msbuild * wget babylon.max.js * command line script (#7) * curl ? * path of exe * exe name ? * test with failing validation * working dir * 2nd try * Update README.md * Update README.md * Update README.md * Update README.md * Canvas polyfill PoC * Fix build with 3rd party sources * canvas font infos * init canvas all platforms * better with includes * android cmake update * flipY * misc * more canvas functions and nanovg * build uwp * bezier curve * split canvas with context and text measurements * better handling of render targets * remove event document * small fixes for VT * web colors * fix color parsing * commit canvass resources * graphics callback * tests * changed button orientation for testing * copy texture defined in experience.js instead of babylon.max.js * removed empty line * copy texture is back * arcana * ios cmake revision * glslang revision * pragma disable pedantic gcc * fixed copy texture * update canvas class name & creation * xr version * heavily WIP * still WIP and debug * it builds * WIP * it builds ! * rollback asio submodule version * text rendering is back * unused parameter * updating .js with latest abstraction changes * scripts update * gcc fixes * missing include * some initial function definitions (#8) * glslang subrepo version * bgfx subrepo version * CMake cleaning * fix conflict * moved test script from experience.js to its own * empty line readme * build option is for clang and not gcc * clean sources * feedback addressed + NPM packages update * empty line * nit * PR feedback Co-authored-by: Cedric Guillemet <ceguille@microsoft.com> Co-authored-by: C. M. Barth <c.m.barth@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.