Conversation
brianvabb
approved these changes
Aug 15, 2022
brianvabb
reviewed
Aug 15, 2022
| if (isNotEmpty(text)) { | ||
| return stream(text.split("[,;\\s]+")) | ||
| return stream(text.split("[,;]+")) | ||
| .map(StringUtils::trimToNull) |
Contributor
There was a problem hiding this comment.
Could be worth extending this test to that oas-examples/petstore.yaml contains tags with white space?
Contributor
Author
There was a problem hiding this comment.
I've had a quick look at that test file and I'm not really sure how best to test that the tags are properly split, to be honest.
@bartveenstra, would welcome any pointers you may have?
ngohungphuc
approved these changes
Aug 15, 2022
Contributor
|
Please add small release note to a readme @daiscog for your changed. Thank you |
|
Kudos, SonarCloud Quality Gate passed!
|
ngohungphuc
approved these changes
Aug 17, 2022
santam85
approved these changes
Aug 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splitting on spaces causes issues where a value contains a legitimate space.
For example, an operation could have a tag with a space in it. Passing that tag to the
apisToGenerateconfig property causes it to be interpreted as two separate tags and therefore it is omitted from the generated APIs.