Skip to content

Do not split on spaces for properties which take a comma-separated list of values #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
santam85 merged 2 commits into from
Aug 22, 2022
Merged

Do not split on spaces for properties which take a comma-separated list of values #316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8bcd95
Do not split on spaces for properties which take a comma-separated li…
daiscog Aug 15, 2022
715f548
Update release notes in README
daiscog Aug 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ The project is very much Work In Progress and will be published on maven central
# Release Notes
BOAT is still under development and subject to change.

## 0.16.3
* *Maven Plugin*
* Do not treat spaces as delimiters in configuration properties which take a comma-separated list of values.
Fixes an issue that prevented the use of tag names containing spaces in the `apisToGenerate` property.
## 0.16.2
* Boat Angular generator
* Specify minimum Angular-related package versions when Angular v13 is used
Expand Down
2 changes: 1 addition & 1 deletion boat-maven-plugin/src/main/java/com/backbase/oss/boat/GenerateMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ public class GenerateMojo extends InputMavenArtifactMojo {

private static String trimCSV(String text) {
if (isNotEmpty(text)) {
return stream(text.split("[,;\\s]+"))
return stream(text.split("[,;]+"))
.map(StringUtils::trimToNull)
Copy link
Copy Markdown
Contributor

@brianvabb brianvabb Aug 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be worth extending this test to that oas-examples/petstore.yaml contains tags with white space?

backbase-openapi-tools/boat-maven-plugin/src/test/java/com/backbase/oss/boat/GenerateMojoTests.java

Line 97 in 9ab36ed

mojo.inputSpec = "src/test/resources/oas-examples/petstore.yaml";

Copy link
Copy Markdown
Contributor Author

@daiscog daiscog Aug 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had a quick look at that test file and I'm not really sure how best to test that the tags are properly split, to be honest.

@bartveenstra, would welcome any pointers you may have?

.filter(Objects::nonNull)
.collect(joining(","));
Expand Down