Skip to content

ci: add PHP 8.5 to test matrix#191

Merged
DASPRiD merged 6 commits intoBacon:mainfrom
Chris53897:patch-1
Nov 15, 2025
Merged

ci: add PHP 8.5 to test matrix#191
DASPRiD merged 6 commits intoBacon:mainfrom
Chris53897:patch-1

Conversation

@Chris53897
Copy link
Copy Markdown
Contributor

@Chris53897 Chris53897 commented Feb 18, 2025

CI fails before this changes. See #192

@DASPRiD
Copy link
Copy Markdown
Member

DASPRiD commented Feb 25, 2025

I'm slightly confused by your three pull requests – plus they are all failing, can you enlighten me? :)

@Chris53897
Copy link
Copy Markdown
Contributor Author

sorry. I updated the description of the PR.
I am not sure if i am able to fix the failing tests. Maybe i can give it a try this weekend.

@ishanvyas22
Copy link
Copy Markdown
Contributor

Since PHP 8.5 is around the corner we should add 8.5 as well.

@DASPRiD
Copy link
Copy Markdown
Member

DASPRiD commented Sep 30, 2025

@ishanvyas22 Would you like forking this PR and fixing the failing tests as well?

@Chris53897 Chris53897 closed this Nov 12, 2025
@Chris53897 Chris53897 reopened this Nov 12, 2025
Updated PHP versions to include 8.5 and upgraded checkout action to v5.
@Chris53897 Chris53897 changed the title ci: Add tests for PHP 8.4 in Pull Requests ci: Add tests for PHP 8.4 and 8.5 Nov 13, 2025
@Chris53897
Copy link
Copy Markdown
Contributor Author

Same 3 issues on PHP 8.5 test-run. That is good news.

@Chris53897 Chris53897 changed the title ci: Add tests for PHP 8.4 and 8.5 ci: Add tests for PHP 8.5 Nov 15, 2025
@DASPRiD
Copy link
Copy Markdown
Member

DASPRiD commented Nov 15, 2025

Can you also update the ci.yml file?

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.59%. Comparing base (762ba02) to head (263d7da).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #191   +/-   ##
=========================================
  Coverage     70.59%   70.59%           
  Complexity      995      995           
=========================================
  Files            49       49           
  Lines          3183     3183           
=========================================
  Hits           2247     2247           
  Misses          936      936           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DASPRiD DASPRiD changed the title ci: Add tests for PHP 8.5 ci: add PHP 8.5 to test matrix Nov 15, 2025
@Chris53897
Copy link
Copy Markdown
Contributor Author

i changed it

@DASPRiD DASPRiD merged commit 7d694a3 into Bacon:main Nov 15, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants