fix(eps): correct elliptic arc to curve conversion sweep handling#233
Merged
fix(eps): correct elliptic arc to curve conversion sweep handling#233
Conversation
The sweep direction logic in EllipticArc::toCurves() did not follow SVG spec F.6.5.6 correctly. It unconditionally subtracted 2π when sweep was false, and never handled the sweep=true with negative delta case. This caused some arcs to trace the wrong direction, resulting in broken rounded corners when rendering QR codes as EPS. Closes #150 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #233 +/- ##
============================================
- Coverage 71.81% 71.77% -0.05%
- Complexity 995 998 +3
============================================
Files 49 49
Lines 3151 3153 +2
============================================
Hits 2263 2263
- Misses 888 890 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sweep direction logic in EllipticArc::toCurves() did not follow SVG spec F.6.5.6 correctly. It unconditionally subtracted 2π when sweep was false, and never handled the sweep=true with negative delta case. This caused some arcs to trace the wrong direction, resulting in broken rounded corners when rendering QR codes as EPS.
Closes #150