Sort the lab results by sequence number and test sort order in the results validation page#13
Merged
Merged
Conversation
Member
|
Please add a unit test. |
Member
|
this introduces newer libraries which is duplicated under 'test/lib'. Please consider removing the older test libraries if you need upgraded ones, and ensuring that all the other tests are passing with the newer ones. the libraries that seem redundant now are - hamcrest-core-1.1.jar, jmock-junit3-2.5.1.jar, mockito-all-1.9.5.jar, objenesis-1.0.jar, junit-4.6.jar |
Member
|
Also please update the PR msg with the JIRA card number |
angshu
approved these changes
May 23, 2018
Mahitha1467
force-pushed
the
psi-release-1.0
branch
from
d063806 to
c5083e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA card: https://bahmni.atlassian.net/browse/BAH-498