chore: bump Go to 1.26.5 (GO-2026-5856)#19
Merged
Merged
Conversation
CI installs Go via go-version-file: go.mod, which pinned 1.26.4. That release is affected by GO-2026-5856 (CVE-2026-42505), a crypto/tls ECH de-anonymization bug fixed in go1.26.5, so govulncheck fails the security job on every branch. Bump the go directive to 1.26.5 to pull the patched standard library. Patch-level bump, no language changes. Verified: go build ./..., go test ./..., and govulncheck ./... (no called vulnerabilities) all pass under 1.26.5.
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
joshraub-bw
approved these changes
Jul 16, 2026
ckoegel
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the
godirective ingo.modfrom1.26.4to1.26.5.CI installs Go via
go-version-file: go.mod, so it was pinned to1.26.4— which is affected by GO-2026-5856 (CVE-2026-42505), acrypto/tlsECH de-anonymization vulnerability fixed in go1.26.5. As a result thesecurityjob'sgovulncheck ./...step fails on every branch (mainincluded — its last run predates the vuln landing in the govulncheck DB). This bumps to the patched release.Patch-level bump — no language or API changes.
Why now
govulncheckfailed the security job on unrelated PRs (e.g. #17). The flagged call sites (internal/api/client.go,internal/output/output.go,internal/testutil/golden.go) are all in the stdlib TLS path, not in any feature branch's changes — it's the pinned toolchain, so it's fixed here once for the whole repo.Verification (local, under go1.26.5)
go build ./...— cleango test ./...— all passgovulncheck ./...— no vulnerabilities in called code (GO-2026-5856 resolved)🤖 Generated with Claude Code