Skip to content

fix(design): block validator egress and harden review key exposure - #102

Merged
echobt merged 2 commits into
mainfrom
fix/design-review-environ-egress
Aug 8, 2026
Merged

fix(design): block validator egress and harden review key exposure#102
echobt merged 2 commits into
mainfrom
fix/design-review-environ-egress

Conversation

@echobt

@echobt echobt commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add validator to Design egress BLOCKED_HOSTNAMES (defense-in-depth alongside post-DNS IP deny).
  • Stop putting OPENROUTER_API_KEY in the design-review container environ; mount it as OPENROUTER_API_KEY_FILE under /run/review-secrets (Linux /proc/<pid>/environ is a boot-time snapshot and cannot be scrubbed by unsetenv).
  • Harden run_command: keep child env_clear, deny procfs and review-secrets paths. Document that AGENTIC_ENABLE_RUN_COMMAND=1 stays on in prod with these mitigations.

Test plan

  • cargo test -p design-egress-proxy -p challenge-agentic -p review-docker --lib
  • cargo clippy -p design-egress-proxy -p challenge-agentic -p review-docker -p challenge-review-bin --all-targets -- -D warnings
  • cargo run -p xtask -- design-check
  • After deploy: confirm review containers receive OPENROUTER_API_KEY_FILE (not OPENROUTER_API_KEY=) and egress still blocks validator by name

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@echobt, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 43 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
鈿欙笍 Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3b83cfdf-28cc-478c-9080-377452342ff2

馃摜 Commits

Reviewing files that changed from the base of the PR and between 966102d and 1e9505a.

馃搾 Files selected for processing (6)
  • bins/challenge-review/src/main.rs
  • crates/challenge-agentic/src/tools.rs
  • crates/design-egress-proxy/src/lib.rs
  • crates/review-docker/src/lib.rs
  • docs/DESIGN_CHALLENGE.md
  • docs/OPERATOR_SECURITY.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

鉂わ笍 Share

Comment @coderabbitai help to get the list of available commands.

echobt added 2 commits August 8, 2026 19:35
Keep OpenRouter out of design-review process environ (file mount +
run_command procfs/secrets deny) and add validator to the egress hostname
blocklist so sandboxes cannot reach co-located control-plane services.
Trim run_command path denies and drop the unused take_openrouter helper
so challenge-agentic stays within the 1500 non-test LOC gate.
@echobt
echobt force-pushed the fix/design-review-environ-egress branch from 607ffaa to 1e9505a Compare August 8, 2026 19:37
@echobt
echobt merged commit c8edae5 into main Aug 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant