Inspect base items of large sequences when checking nondeterminism#2726
Closed
GuntherRademacher wants to merge 1 commit into
Closed
Inspect base items of large sequences when checking nondeterminism#2726GuntherRademacher wants to merge 1 commit into
GuntherRademacher wants to merge 1 commit into
Conversation
ChristianGruen
added a commit
that referenced
this pull request
Jul 22, 2026
Member
|
I have chosen a slightly different fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to the recent atomic-type check in
DynFuncCall.containsNdtFunction, which still walked every item of large non-atomic sequences and arrays, e.g.The check now inspects the compact base items instead: a new
Value.baseItems()(overridden inSingletonSeqandSubSeq) collapsesfn:replicatesequences, and arrays are inspected via anItemArray's backing or a multi-member array's members (never flattened).Regression tests have been added to
NonDeterministicTest.