Add LRU cache for generated parsers to FnInvisibleXml - #2749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an LRU cache for Markup-Blitz-generated parsers to
FnInvisibleXml(generated parsers are stateless and safe to share concurrently). The cache is limited to a fixed size of 15.The XQuery code below can be used to demonstrate the performance difference that is gained by adding the cache. It repeatedly parses a number of small documents with a JSON grammar (returning the count of result nodes). It runs about 20 times faster with the cache.
JSON parser cache benchmark