Skip to content

SCA-235: install git for desktop backend runtime lock - #10807

Merged
Git-on-my-level merged 1 commit into
mainfrom
fix/sca-235-desktop-backend-git
Jul 29, 2026
Merged

SCA-235: install git for desktop backend runtime lock#10807
Git-on-my-level merged 1 commit into
mainfrom
fix/sca-235-desktop-backend-git

Conversation

@Git-on-my-level

@Git-on-my-level Git-on-my-level commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

Context

Follow-up to #10686. The dev deployment failed during its image build: https://github.com/BasedHardware/omi/actions/runs/30405177980

The slim Python builder ran uv pip sync without Git, while pyogg is locked from git+https://github.com/TeamPyOgg/PyOgg. The agent-VM lock has no Git-sourced dependency, so its Dockerfile is unchanged.

Verification

  • make setup
  • make preflight
  • docker build -f backend/Dockerfile.desktop_backend . (blocked before build layers because the local Docker daemon lacks authentication to pull gcr.io/based-hardware-dev/python:3.11-slim-forky; GCR returned 403)
  • confirmed pylock.runtime.toml retains the Git VCS entry for pyogg, and the Dockerfile installs Git before uv pip sync

Residual risk

The full image build remains to be exercised by authenticated CI. This change deliberately adds only Git, not compilers or unrelated build tooling.

Failure-Class: none

Closes SCA-235

Review in cubic

@Git-on-my-level
Git-on-my-level merged commit 60b87b1 into main Jul 29, 2026
42 checks passed
@Git-on-my-level
Git-on-my-level deleted the fix/sca-235-desktop-backend-git branch July 29, 2026 02:36
Git-on-my-level added a commit that referenced this pull request Jul 29, 2026
… build (#10816)

## Summary

- Add `gcc` to `backend/Dockerfile.desktop_backend` apt-get install line
- Unblocks `webrtcvad==2.0.10` C extension build during `uv pip sync`

## Context

Follow-up to #10686 (replace Rust cloud backend with Python) and #10807
(add git for pyogg VCS source).

The dev deployment has failed on every post-merge run since #10686
landed. The error:

```
webrtcvad==2.0.10 → gcc: No such file or directory
error: command 'gcc' failed: No such file or directory
```

`webrtcvad` compiles a C extension (`_webrtcvad`) and needs a C compiler
in the builder image. The slim Python base image ships no compiler
toolchain.

## Verification

- Confirmed `pylock.runtime.toml` locks `webrtcvad==2.0.10` which
requires C compilation
- Diff adds only `gcc` to the existing apt-get line (no other changes)
- CI auto-dev workflow will exercise the full Docker build on next push

Failure-Class: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant