chore(dev): add personal build config overlay for local dev builds - #11789
Conversation
Introduces a .personal_configs/ convention at the repo root for contributors to store machine-local Firebase credentials and dev env config without committing them. Run app/setup-personal.sh after setup.sh to copy them into place. Split out of BasedHardware#7641 at maintainer request (community-build signing fix and this overlay are unrelated concerns and easier to review apart) — carries the same content as that PR's commits 1295dc3/b246990fa9, rebased onto current main. Failure-Class: none
Moved to BasedHardware#11789 at @Git-on-my-level's request — the community-build signing fix (dynamic DEVELOPMENT_TEAM/APP_GROUP_IDENTIFIER, stripped dev entitlements) and this overlay are unrelated concerns and easier to review and land independently. Failure-Class: none
|
Thanks for the clean split out of #7641 — I verified file-by-file that this PR stands on its own against
Two small non-blocking notes:
Checks that ran (Dart Analyze & Tests, Formatting, Hygiene, Backend Hermetic Merge Gate) all pass; the skipped heavier jobs are expected for non-app-code changes. Nice developer-experience contribution — the warning about by AI on behalf of David — if you need David’s attention urgently, please @Git-on-my-level and escalate with |
|
All CI checks are green and the review above raised no blocking issues — this is ready for maintainer merge whenever convenient. I don't have write access to merge it myself. |
Summary
Split out of #7641 at maintainer request — that PR mixed two unrelated concerns (dynamic
DEVELOPMENT_TEAM/entitlements signing fix, and this personal-configs overlay), and splitting makes both easier to review and land independently.Introduces a
.personal_configs/convention at the repo root for contributors to store machine-local Firebase credentials and dev env config without committing them:.personal_configs.example/— templates for.dev.env,GoogleService-Info.plist, andfirebase_options_dev.dart, with instructions for where to get real valuesapp/setup-personal.sh— copies.personal_configs/into the app tree aftersetup.sh, with an optional ngrok-URL override forAPI_BASE_URL.personal_configs/added to.gitignoreso real credentials never get committedCarries the same content as #7641's commits
1295dc33a2/b246990fa9, rebased onto currentmain— no functional changes from what was already reviewed there.Known nit (carried forward, not fixed here)
setup-personal.shusessed -i ''(BSD/macOS syntax) — fine since this is iOS-only tooling, but flagged in the original PR review as worth a comment if Linux contributors might use it. Left as-is to keep this a pure split with no new changes; happy to address in review if wanted.Failure-Class: none