Skip to content

Only log permission checks on status change#5262

Merged
m13v merged 2 commits intomainfrom
feat/cloud-agents-chat
Mar 1, 2026
Merged

Only log permission checks on status change#5262
m13v merged 2 commits intomainfrom
feat/cloud-agents-chat

Conversation

@m13v
Copy link
Copy Markdown
Contributor

@m13v m13v commented Mar 1, 2026

Summary

  • Stop logging ACCESSIBILITY_CHECK and AUTOMATION_CHECK on every 1-second timer tick
  • Only log when permission status actually changes (granted ↔ revoked, broken ↔ working)
  • Fixes Sentry breadcrumb flooding — permission check logs were filling the 100-breadcrumb buffer within seconds, pushing out all useful diagnostic logs

Test plan

  • Verify permission checks still detect changes (grant/revoke accessibility)
  • Verify Sentry breadcrumbs contain useful logs instead of permission check spam

🤖 Generated with Claude Code

@m13v m13v merged commit f871d8b into main Mar 1, 2026
1 check passed
@m13v m13v deleted the feat/cloud-agents-chat branch March 1, 2026 04:40
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Mar 1, 2026

Greptile Summary

Prevents Sentry breadcrumb flooding by only logging permission check results when the status actually changes, rather than on every 1-second timer tick. The implementation compares the new permission state against the previous state and only logs transitions (granted ↔ revoked, broken ↔ working). Also includes an unrelated fix to export CHANGELOG_JSON in the Codemagic workflow so it's properly available to the Python script that registers releases in Firestore.

Confidence Score: 5/5

  • Safe to merge — straightforward logging optimization with clear state-change detection logic
  • The changes are minimal, well-scoped, and directly address the stated problem. The state-change detection logic is sound (comparing current vs previous values before logging), and the codemagic.yaml fix is a standard shell export correction
  • No files require special attention

Important Files Changed

Filename Overview
desktop/Desktop/Sources/AppState.swift Added state-change detection to only log permission checks when status changes (granted/revoked or broken/working), preventing Sentry breadcrumb flooding
codemagic.yaml Fixed CHANGELOG_JSON variable export so it's available to child Python process when registering release in Firestore

Last reviewed commit: 8704668

Glucksberg pushed a commit to Glucksberg/omi-local that referenced this pull request Apr 28, 2026
## Summary
- Stop logging ACCESSIBILITY_CHECK and AUTOMATION_CHECK on every
1-second timer tick
- Only log when permission status actually changes (granted ↔ revoked,
broken ↔ working)
- Fixes Sentry breadcrumb flooding — permission check logs were filling
the 100-breadcrumb buffer within seconds, pushing out all useful
diagnostic logs

## Test plan
- [ ] Verify permission checks still detect changes (grant/revoke
accessibility)
- [ ] Verify Sentry breadcrumbs contain useful logs instead of
permission check spam

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant