Skip to content

Only log permission checks on status change #5262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m13v merged 2 commits into from
Mar 1, 2026
Merged

Only log permission checks on status change #5262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc104f6
Fix missing export for CHANGELOG_JSON in Codemagic Firestore step
github-actions[bot] Mar 1, 2026
8704668
Only log permission checks on status change, not every second
github-actions[bot] Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion codemagic.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2407,7 +2407,7 @@ workflows:

- name: Register release in Firestore
script: |
CHANGELOG_JSON=$(echo "$CHANGELOG_JSON_B64" | base64 --decode)
export CHANGELOG_JSON=$(echo "$CHANGELOG_JSON_B64" | base64 --decode)

RELEASE_JSON=$(python3 - <<PYEOF
import json, os
Expand Down
17 changes: 13 additions & 4 deletions desktop/Desktop/Sources/AppState.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -836,7 +836,10 @@ class AppState: ObservableObject {
}
} else {
let hasPermission = status == noErr
log("AUTOMATION_CHECK: status=\(status), hasPermission=\(hasPermission)")
let previousValue = await MainActor.run { self.hasAutomationPermission }
if hasPermission != previousValue {
log("AUTOMATION_CHECK: status=\(status), hasPermission=\(hasPermission)")
}

await MainActor.run {
self.hasAutomationPermission = hasPermission
Expand Down Expand Up @@ -897,15 +900,21 @@ class AppState: ObservableObject {
// AXIsProcessTrusted() says not granted — but on macOS 26 this may be stale.
// Probe via event tap which checks the live TCC database.
if probeAccessibilityViaEventTap() {
log("ACCESSIBILITY_CHECK: AXIsProcessTrusted() returned false but event tap succeeded — stale cache detected")
if !previouslyGranted {
log("ACCESSIBILITY_CHECK: AXIsProcessTrusted() returned false but event tap succeeded — stale cache detected")
}
let axWorks = testAccessibilityPermission()
hasAccessibilityPermission = true
if !axWorks {
if !isAccessibilityBroken {
log("ACCESSIBILITY_CHECK: Event tap OK but AX calls fail — marking as broken")
}
isAccessibilityBroken = true
log("ACCESSIBILITY_CHECK: Event tap OK but AX calls fail — marking as broken")
} else {
if isAccessibilityBroken {
log("ACCESSIBILITY_CHECK: Permission confirmed via event tap probe, AX calls working")
}
isAccessibilityBroken = false
log("ACCESSIBILITY_CHECK: Permission confirmed via event tap probe, AX calls working")
}
} else {
// Event tap also failed — permission genuinely not granted
Expand Down