Skip to content

Add trust/permissions message to onboarding#5292

Merged
kodjima33 merged 1 commit intomainfrom
fix/onboarding-trust-message
Mar 3, 2026
Merged

Add trust/permissions message to onboarding#5292
kodjima33 merged 1 commit intomainfrom
fix/onboarding-trust-message

Conversation

@kodjima33
Copy link
Copy Markdown
Collaborator

Summary

  • After name confirmation, tells user upfront about permissions and file access needed
  • Reassures user about open-source, transparency, and data encryption

Test plan

  • Complete onboarding flow and verify the new message appears after confirming name

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@kodjima33 kodjima33 merged commit 2a9617f into main Mar 3, 2026
1 check passed
@kodjima33 kodjima33 deleted the fix/onboarding-trust-message branch March 3, 2026 02:05
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Mar 3, 2026

Greptile Summary

Adds a transparency and trust message to the onboarding flow after name confirmation, informing users about upcoming permission requests and file access needs.

Issues Found:

  • Invalid template variable {name} will not be replaced at runtime (should be {user_given_name})
  • Grammar error: missing verb "is" in "All your data belongs to you and encrypted!"

Confidence Score: 2/5

  • This PR has a critical bug that will show raw template variable {name} to users instead of their name
  • The invalid template variable {name} is a critical issue that will break the user experience by displaying unreplaced template syntax. Combined with a grammar error, this PR needs fixes before merge.
  • ChatPrompts.swift requires attention for template variable and grammar fixes

Important Files Changed

Filename Overview
desktop/Desktop/Sources/Chat/ChatPrompts.swift Added trust/permissions message to onboarding flow, but contains invalid template variable and grammar error

Last reviewed commit: 7590396

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

Use `ask_followup` with options like ["Yes!", "Call me something else"].
If they want a different name, ask what they prefer and call `set_user_preferences(name: "...")`.
If confirmed, move on.
If confirmed, say: "Nice to meet you {name}! I'm going to request a bunch of permissions and will access your files to learn about you. I won't function well if you don't grant it.\n\nYou can trust me — I'm fully open-source, transparent and secure. All your data belongs to you and encrypted!"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{name} is not a valid template variable. Use {user_given_name} instead, which is properly replaced in buildOnboardingChat() function (line 1445).

Suggested change
If confirmed, say: "Nice to meet you {name}! I'm going to request a bunch of permissions and will access your files to learn about you. I won't function well if you don't grant it.\n\nYou can trust me — I'm fully open-source, transparent and secure. All your data belongs to you and encrypted!"
If confirmed, say: "Nice to meet you {user_given_name}! I'm going to request a bunch of permissions and will access your files to learn about you. I won't function well if you don't grant it.\n\nYou can trust me — I'm fully open-source, transparent and secure. All your data belongs to you and encrypted!"

Use `ask_followup` with options like ["Yes!", "Call me something else"].
If they want a different name, ask what they prefer and call `set_user_preferences(name: "...")`.
If confirmed, move on.
If confirmed, say: "Nice to meet you {name}! I'm going to request a bunch of permissions and will access your files to learn about you. I won't function well if you don't grant it.\n\nYou can trust me — I'm fully open-source, transparent and secure. All your data belongs to you and encrypted!"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing verb in sentence: "All your data belongs to you and encrypted!" should be "and is encrypted!"

Suggested change
If confirmed, say: "Nice to meet you {name}! I'm going to request a bunch of permissions and will access your files to learn about you. I won't function well if you don't grant it.\n\nYou can trust me — I'm fully open-source, transparent and secure. All your data belongs to you and encrypted!"
If confirmed, say: "Nice to meet you {name}! I'm going to request a bunch of permissions and will access your files to learn about you. I won't function well if you don't grant it.\n\nYou can trust me — I'm fully open-source, transparent and secure. All your data belongs to you and is encrypted!"

Glucksberg pushed a commit to Glucksberg/omi-local that referenced this pull request Apr 28, 2026
## Summary
- After name confirmation, tells user upfront about permissions and file
access needed
- Reassures user about open-source, transparency, and data encryption

## Test plan
- [ ] Complete onboarding flow and verify the new message appears after
confirming name

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant