Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion desktop/Desktop/Sources/Chat/ChatPrompts.swift
Original file line number Diff line number Diff line change
Expand Up @@ -668,7 +668,7 @@ struct ChatPrompts {
Say hi to {user_given_name} and confirm the name. Example: "Hey {user_given_name}! That's what I should call you, right?"
Use `ask_followup` with options like ["Yes!", "Call me something else"].
If they want a different name, ask what they prefer and call `set_user_preferences(name: "...")`.
If confirmed, move on.
If confirmed, say: "Nice to meet you {name}! I'm going to request a bunch of permissions and will access your files to learn about you. I won't function well if you don't grant it.\n\nYou can trust me — I'm fully open-source, transparent and secure. All your data belongs to you and encrypted!"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{name} is not a valid template variable. Use {user_given_name} instead, which is properly replaced in buildOnboardingChat() function (line 1445).

Suggested change
If confirmed, say: "Nice to meet you {name}! I'm going to request a bunch of permissions and will access your files to learn about you. I won't function well if you don't grant it.\n\nYou can trust me — I'm fully open-source, transparent and secure. All your data belongs to you and encrypted!"
If confirmed, say: "Nice to meet you {user_given_name}! I'm going to request a bunch of permissions and will access your files to learn about you. I won't function well if you don't grant it.\n\nYou can trust me — I'm fully open-source, transparent and secure. All your data belongs to you and encrypted!"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing verb in sentence: "All your data belongs to you and encrypted!" should be "and is encrypted!"

Suggested change
If confirmed, say: "Nice to meet you {name}! I'm going to request a bunch of permissions and will access your files to learn about you. I won't function well if you don't grant it.\n\nYou can trust me — I'm fully open-source, transparent and secure. All your data belongs to you and encrypted!"
If confirmed, say: "Nice to meet you {name}! I'm going to request a bunch of permissions and will access your files to learn about you. I won't function well if you don't grant it.\n\nYou can trust me — I'm fully open-source, transparent and secure. All your data belongs to you and is encrypted!"

Then call `save_knowledge_graph` with just the user's name as a person node. This seeds the live graph with their name at the center.

STEP 1.5 — LANGUAGE PREFERENCE
Expand Down