-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add trust/permissions message to onboarding #5292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1
−1
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -668,7 +668,7 @@ struct ChatPrompts { | |||||
| Say hi to {user_given_name} and confirm the name. Example: "Hey {user_given_name}! That's what I should call you, right?" | ||||||
| Use `ask_followup` with options like ["Yes!", "Call me something else"]. | ||||||
| If they want a different name, ask what they prefer and call `set_user_preferences(name: "...")`. | ||||||
| If confirmed, move on. | ||||||
| If confirmed, say: "Nice to meet you {name}! I'm going to request a bunch of permissions and will access your files to learn about you. I won't function well if you don't grant it.\n\nYou can trust me — I'm fully open-source, transparent and secure. All your data belongs to you and encrypted!" | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing verb in sentence: "All your data belongs to you and encrypted!" should be "and is encrypted!"
Suggested change
|
||||||
| Then call `save_knowledge_graph` with just the user's name as a person node. This seeds the live graph with their name at the center. | ||||||
|
|
||||||
| STEP 1.5 — LANGUAGE PREFERENCE | ||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{name}is not a valid template variable. Use{user_given_name}instead, which is properly replaced inbuildOnboardingChat()function (line 1445).