Revert "feat(desktop): route beta channel to dev backend"

[kodjima33]

Reverts #7224. The change was merged before being validated locally; we want to test the dev-backend routing on a named local bundle first (using the OMI_FORCE_DEV_BACKENDS override I added in that PR — except the env-var didn't actually reach the launched .app because run.sh loads URLs via a baked Contents/Resources/.env, not shell env). Reverting on main, validating locally, then redoing.

The diagnostic PR #7227 stays — that's an unrelated workflow hardening that's useful regardless.

🤖 Generated with Claude Code

[greptile-apps]

Greptile Summary

This revert disables the beta-channel → development-backend routing introduced in #7224, after discovering that the dev backend mints fresh Firebase UIDs for existing prod users (causing data isolation issues). The shouldUseDevelopmentBackends function now unconditionally returns false, keeping all builds on production backends until the auth flow is fixed and the change can be validated locally first.

• DesktopBackendEnvironment.swift: shouldUseDevelopmentBackends hardcoded to false; forceOverride/OMI_FORCE_DEV_BACKENDS support and isAffirmative helper removed. normalizedChannel is now dead code (left behind, not removed).
• APIClientRoutingTests.swift: Previous beta-routing and force-override tests replaced with a single testDevelopmentBackendRoutingDisabled test that asserts false across all input combinations.

Confidence Score: 4/5

Safe to merge — all builds will continue routing to production backends, and the revert correctly undoes the problematic beta-channel routing.

The change is a clean, well-motivated revert. The only rough edges are two leftover artefacts: the normalizedChannel private helper is now unreferenced dead code, and the bundleIdentifier/updateChannel parameters are accepted but ignored. Neither affects runtime behavior, but they leave the codebase slightly messier than it needs to be for what is described as a temporary state.

desktop/Desktop/Sources/DesktopBackendEnvironment.swift — dead normalizedChannel function and unused parameters worth cleaning up before the feature is re-landed.

Important Files Changed

Filename	Overview
desktop/Desktop/Sources/DesktopBackendEnvironment.swift	Reverts beta-to-dev backend routing by hardcoding shouldUseDevelopmentBackends to false; removes forceOverride/isAffirmative helpers. Leaves normalizedChannel as dead code and keeps unused bundleIdentifier/updateChannel parameters.
desktop/Desktop/Tests/APIClientRoutingTests.swift	Collapses the four beta-routing tests into a single testDevelopmentBackendRoutingDisabled method that asserts false for all input combinations; all other routing coverage is untouched.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[App launch] --> B{shouldUseDevelopmentBackends}
    B -- "always false (post-revert)" --> C[Use production backends]
    C --> D[api.omi.me Python API]
    C --> E[desktop-backend prod Rust API]

    B -. "intended future path\n(re-land after auth fix)" .-> F{bundleId == prod\nAND channel == beta?}
    F -- Yes --> G[Use development backends]
    F -- No --> C
    G --> H[api.omiapi.com Python API]
    G --> I[desktop-backend dev Rust API]

Loading

Comments Outside Diff (1)

1. desktop/Desktop/Sources/DesktopBackendEnvironment.swift, line 87-92 (link)

   The normalizedChannel private helper is now dead code — it was only called inside shouldUseDevelopmentBackends, which now returns false unconditionally without referencing it. Swift will emit a warning for unreferenced private functions in strict builds, and the dead symbol creates confusion for anyone re-landing the feature. It should be removed alongside the routing logic it supported.

_{Reviews (1): Last reviewed commit: "Revert "feat(desktop): route beta channe..." | Re-trigger Greptile}

[greptile-apps]

Both bundleIdentifier and updateChannel are now unused parameters in shouldUseDevelopmentBackends. The call-site in the computed shouldUseDevelopmentBackends var still passes them, but the function body ignores them entirely. Swift may warn about unused variables here, and it creates a misleading API surface — callers could reasonably assume the values affect the result. Dropping them from the signature (and the call-site) makes the temporary return false state self-documenting.

Suggested change

	static func shouldUseDevelopmentBackends(
	bundleIdentifier: String,
	updateChannel: String,
	forceOverride: String? = nil
	updateChannel: String
	) -> Bool {
	static func shouldUseDevelopmentBackends(
	bundleIdentifier: String = "",
	updateChannel: String = ""
	) -> Bool {