Reapply: route desktop beta channel to dev backend

[kodjima33]

Reapplies #7224 after the #7230 revert. Verified locally this time:

• Named bundle (com.omi.omi-beta-dev-test) launched with shell-bundled dev URLs (OMI_PYTHON_API_URL=https://api.omiapi.com/, OMI_DESKTOP_API_URL=https://desktop-backend-dt5lrfkkoa-uc.a.run.app/).
• Signed in with kodjima33@gmail.com — landed on prod UID viUv7GtdoHXbK1UBCDlPuTDuPgJ2 (not a ghost dev UID).
• Existing chat history and tasks loaded.
• New requests go through dev backend: POST https://api.omiapi.com/v2/desktop/messages, /v3/memories, /v1/action-items — all succeeding, AgentSync pushing rows.
• Confirms dev backend's SERVICE_ACCOUNT_JSON, FIREBASE_API_KEY, FIREBASE_PROJECT_ID are all on prod Firebase (based-hardware), so dev-issued custom tokens resolve to the same prod UID.

This time the change ships through the existing #7227 diagnostic patch (already on main), so if Codemagic's universal-bundle step trips again we'll get a real error instead of a 0.6s opaque failure.

🤖 Generated with Claude Code

[greptile-apps]

Greptile Summary

This PR re-enables beta-to-dev backend routing for the desktop app's production bundle (com.omi.computer-macos), replacing the hard-coded return false guard that was put in place after the previous revert. It also introduces an OMI_FORCE_DEV_BACKENDS escape hatch so non-production bundles can opt in explicitly.

• DesktopBackendEnvironment.swift: shouldUseDevelopmentBackends now returns true when the production bundle is on the beta/staging channel, or unconditionally when OMI_FORCE_DEV_BACKENDS is set to "1", "true", or "yes". The new isAffirmative helper handles the env-var check.
• APIClientRoutingTests.swift: Test function previously asserting false for all cases is replaced by four targeted functions covering the beta+prod-bundle true path, stable false path, non-prod bundle false path, and force-override path.

Confidence Score: 4/5

Safe to merge — the routing logic is gated correctly on the production bundle identifier and beta channel, with the force-override only reachable via an explicitly set env var.

The change is narrow and well-tested. The only findings are a missing "yes" test case for isAffirmative and a stale log message in applyReleaseChannelDefaults that says "beta channel" even when the force-override path triggers it — neither affects runtime correctness.

Both files are straightforward; the only items worth a second look are the applyReleaseChannelDefaults log string and the missing "yes" test case in APIClientRoutingTests.

Important Files Changed

Filename	Overview
desktop/Desktop/Sources/DesktopBackendEnvironment.swift	Re-enables beta-to-dev routing for the production bundle by replacing the hard-coded return false with a bundle+channel check; adds OMI_FORCE_DEV_BACKENDS escape hatch via a new isAffirmative helper. Logic is sound and well-commented.
desktop/Desktop/Tests/APIClientRoutingTests.swift	Tests are updated to reflect the new routing semantics. New test functions cover the beta+prod-bundle true path, stable false path, non-prod bundle false path, and force-override path. One accepted affirmative value ("yes") is not exercised by any test case.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[shouldUseDevelopmentBackends called] --> B{OMI_FORCE_DEV_BACKENDS\nisAffirmative?}
    B -- yes --> C[return true\nUse dev backends]
    B -- no --> D{bundleIdentifier ==\ncom.omi.computer-macos?}
    D -- no --> E[return false\nUse prod backends]
    D -- yes --> F{normalizedChannel ==\n'beta'?}
    F -- no --> G[return false\nUse prod backends]
    F -- yes --> H[return true\nUse dev backends]

Loading

Comments Outside Diff (1)

1. desktop/Desktop/Sources/DesktopBackendEnvironment.swift, line 98 (link)

   The applyReleaseChannelDefaults log message still says "beta channel" but shouldUseDevelopmentBackends can now return true via the OMI_FORCE_DEV_BACKENDS path on any bundle/channel combination. A developer debugging a force-override scenario will see a misleading message that suggests they're on the beta channel when they may not be.

_{Reviews (1): Last reviewed commit: "Reapply "feat(desktop): route beta chann..." | Re-trigger Greptile}

[greptile-apps]

isAffirmative explicitly accepts "yes" as a truthy value but no test exercises it. If the acceptance of "yes" is ever accidentally removed from the helper (e.g., someone trims the list to just "1" and "true"), this test suite would not catch the regression.

Suggested change

	XCTAssertTrue(DesktopBackendEnvironment.shouldUseDevelopmentBackends(
	bundleIdentifier: "com.omi.omi-beta-dev-test",
	updateChannel: "stable",
	forceOverride: "true"
	))
	XCTAssertFalse(DesktopBackendEnvironment.shouldUseDevelopmentBackends(
	bundleIdentifier: "com.omi.computer-macos",
	updateChannel: "stable",
	forceOverride: "0"
	))
	XCTAssertTrue(DesktopBackendEnvironment.shouldUseDevelopmentBackends(
	bundleIdentifier: "com.omi.omi-beta-dev-test",
	updateChannel: "stable",
	forceOverride: "true"
	))
	XCTAssertTrue(DesktopBackendEnvironment.shouldUseDevelopmentBackends(
	bundleIdentifier: "com.omi.omi-beta-dev-test",
	updateChannel: "stable",
	forceOverride: "yes"
	))
	XCTAssertFalse(DesktopBackendEnvironment.shouldUseDevelopmentBackends(
	bundleIdentifier: "com.omi.computer-macos",
	updateChannel: "stable",
	forceOverride: "0"
	))