Skip to content

[codex] Harden Windows memory dump parsing#7900

Merged
kodjima33 merged 2 commits into
BasedHardware:mainfrom
tianmind-studio:codex/windows-memory-import-markdown-fences
Jul 3, 2026
Merged

[codex] Harden Windows memory dump parsing#7900
kodjima33 merged 2 commits into
BasedHardware:mainfrom
tianmind-studio:codex/windows-memory-import-markdown-fences

Conversation

@tianmind-studio

@tianmind-studio tianmind-studio commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Skip Markdown code fence lines when parsing pasted ChatGPT/Claude memory dumps.
  • Strip additional common pasted list markers, including em dash, triangular bullet, and hyphen bullet variants.
  • Add focused coverage for fenced dumps and richer pasted list markers.
  • Format the touched fence test with the current Windows app dev dependencies.

Why

Windows users often copy memory lists from chat surfaces that wrap content in Markdown fences or use typographic bullets/dashes. The existing parser could keep ``` fences as bogus memories and leave some common marker characters in the imported text.

Refresh

  • Rebased on main at b781d91767ac96a20f2305614eb50c7744a8a6c3.
  • Current head: 22e3d0ca67e4c7afe4141ad3fb919f1d7dec5f89.
  • GitHub currently reports this PR as mergeable.

Validation

  • From desktop/windows/: npm run test -- src/main/memoryImport/parse.test.ts -> 1 file, 8 tests passed
  • From desktop/windows/: npm run typecheck -> passed
  • targeted npx eslint --quiet on changed Windows files -> no errors
  • git diff --check origin/main...HEAD -> passed
  • git diff --check -> passed
  • scripts/pre-commit with PYTHONUTF8=1 -> passed
  • scripts/pre-push with PYTHONUTF8=1 -> passed

@tianmind-studio tianmind-studio force-pushed the codex/windows-memory-import-markdown-fences branch 3 times, most recently from 1d014a7 to 0ec577f Compare June 23, 2026 07:02

@Git-on-my-level Git-on-my-level left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tightening up the Windows memory import parser. This is a focused, low-risk improvement: it correctly skips Markdown fence lines, expands support for common pasted bullet markers, and includes targeted Vitest coverage for both behaviors. The existing lint/format check is passing, and I did not see any security, dependency, workflow, or product-scope concerns.

@tianmind-studio tianmind-studio force-pushed the codex/windows-memory-import-markdown-fences branch 3 times, most recently from c115e27 to ea32b03 Compare July 3, 2026 05:19
@tianmind-studio tianmind-studio force-pushed the codex/windows-memory-import-markdown-fences branch from ea32b03 to 22e3d0c Compare July 3, 2026 10:54

@kodjima33 kodjima33 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Desktop bug fix (owner-override): harden Windows memory-dump parsing (skip code fences, more list markers).

@kodjima33 kodjima33 merged commit c6708da into BasedHardware:main Jul 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants