[codex] Harden Windows memory dump parsing#7900
Merged
kodjima33 merged 2 commits intoJul 3, 2026
Merged
Conversation
1d014a7 to
0ec577f
Compare
Git-on-my-level
approved these changes
Jun 26, 2026
Git-on-my-level
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for tightening up the Windows memory import parser. This is a focused, low-risk improvement: it correctly skips Markdown fence lines, expands support for common pasted bullet markers, and includes targeted Vitest coverage for both behaviors. The existing lint/format check is passing, and I did not see any security, dependency, workflow, or product-scope concerns.
c115e27 to
ea32b03
Compare
ea32b03 to
22e3d0c
Compare
kodjima33
approved these changes
Jul 3, 2026
kodjima33
left a comment
Collaborator
There was a problem hiding this comment.
Desktop bug fix (owner-override): harden Windows memory-dump parsing (skip code fences, more list markers).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Windows users often copy memory lists from chat surfaces that wrap content in Markdown fences or use typographic bullets/dashes. The existing parser could keep ``` fences as bogus memories and leave some common marker characters in the imported text.
Refresh
mainatb781d91767ac96a20f2305614eb50c7744a8a6c3.22e3d0ca67e4c7afe4141ad3fb919f1d7dec5f89.Validation
desktop/windows/:npm run test -- src/main/memoryImport/parse.test.ts-> 1 file, 8 tests passeddesktop/windows/:npm run typecheck-> passednpx eslint --quieton changed Windows files -> no errorsgit diff --check origin/main...HEAD-> passedgit diff --check-> passedscripts/pre-commitwithPYTHONUTF8=1-> passedscripts/pre-pushwithPYTHONUTF8=1-> passed