[codex] Keep Windows app checkouts on LF#7934
Conversation
e607818 to
be489b4
Compare
ClawSweeper local pilot reviewRecommendation: keep open; looks suitable for normal maintainer review. What it found:
Suggested next step: merge if maintainers want Git checkout behavior to match the existing LF formatter policy. Posted from a local report-only ClawSweeper pilot by request; no labels, closes, repairs, or merges were performed. |
5ea4602 to
9d61b5f
Compare
Git-on-my-level
left a comment
There was a problem hiding this comment.
Thanks for the focused fix. This is a small, scoped repository-hygiene change under the Windows app: it aligns Git checkout EOL handling with the existing desktop/windows .editorconfig LF policy, avoids weakening Prettier, and the lint/format check is passing. I don’t see security, dependency, workflow, or product-direction concerns here.
9d61b5f to
b47cdd3
Compare
|
Thanks @tianmind-studio — verified this independently.
Nicely done. — automated maintainer review (Omi PR monitor, glm-5.2) |
e0cd3b8 to
713eb43
Compare
713eb43 to
6b6ec71
Compare
kodjima33
left a comment
There was a problem hiding this comment.
Desktop chore: scoped .gitattributes to keep Windows app checkouts on LF.
Summary
.gitattributesfile underdesktop/windows..editorconfigand Prettier setup.Why
On this Windows checkout,
desktop/windowsfiles were written with CRLF becausecore.autocrlf=true. The Windows app already declaresend_of_line = lfin.editorconfig, so ESLint/Prettier reported almost every line asDelete CR, hiding the real lint findings.This keeps the policy local to
desktop/windowsinstead of changing the whole repository or weakening Prettier withendOfLine: auto.Refresh
mainatb781d91767ac96a20f2305614eb50c7744a8a6c3.6b6ec716e1e6bab9d215658f3238c64e9fe4036f.Validation
git check-attr -a -- desktop/windows/electron.vite.config.ts desktop/windows/eslint.config.mjs desktop/windows/.prettierrc.yaml desktop/windows/src/renderer/src/lib/goals.test.ts->text: auto,eol: lffor all four filesgit diff --check origin/main...HEAD-> passedgit diff --check-> passedscripts/pre-commitwithPYTHONUTF8=1-> passedscripts/pre-pushwithPYTHONUTF8=1-> passed