Skip to content

[codex] Keep Windows app checkouts on LF#7934

Merged
kodjima33 merged 1 commit into
BasedHardware:mainfrom
tianmind-studio:codex/windows-prettier-eol
Jul 3, 2026
Merged

[codex] Keep Windows app checkouts on LF#7934
kodjima33 merged 1 commit into
BasedHardware:mainfrom
tianmind-studio:codex/windows-prettier-eol

Conversation

@tianmind-studio

@tianmind-studio tianmind-studio commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add a scoped .gitattributes file under desktop/windows.
  • Force text files in the Windows app subtree to check out with LF line endings.
  • Keep Git checkout behavior aligned with the existing .editorconfig and Prettier setup.

Why

On this Windows checkout, desktop/windows files were written with CRLF because core.autocrlf=true. The Windows app already declares end_of_line = lf in .editorconfig, so ESLint/Prettier reported almost every line as Delete CR, hiding the real lint findings.

This keeps the policy local to desktop/windows instead of changing the whole repository or weakening Prettier with endOfLine: auto.

Refresh

  • Rebased on main at b781d91767ac96a20f2305614eb50c7744a8a6c3.
  • Current head: 6b6ec716e1e6bab9d215658f3238c64e9fe4036f.
  • GitHub currently reports this PR as mergeable.

Validation

  • git check-attr -a -- desktop/windows/electron.vite.config.ts desktop/windows/eslint.config.mjs desktop/windows/.prettierrc.yaml desktop/windows/src/renderer/src/lib/goals.test.ts -> text: auto, eol: lf for all four files
  • git diff --check origin/main...HEAD -> passed
  • git diff --check -> passed
  • scripts/pre-commit with PYTHONUTF8=1 -> passed
  • scripts/pre-push with PYTHONUTF8=1 -> passed

@tianmind-studio tianmind-studio force-pushed the codex/windows-prettier-eol branch from e607818 to be489b4 Compare June 16, 2026 15:25
@ThomsenDrake

Copy link
Copy Markdown
Collaborator

ClawSweeper local pilot review

Recommendation: keep open; looks suitable for normal maintainer review.

What it found:

  • Current main has a Windows .editorconfig requiring LF, but no Git attributes rule enforcing LF checkout behavior for the Windows desktop subtree.
  • This PR adds a scoped desktop/windows/.gitattributes rule and avoids changing repository-wide checkout behavior.
  • No blocking correctness or security finding was found.

Suggested next step: merge if maintainers want Git checkout behavior to match the existing LF formatter policy.

Posted from a local report-only ClawSweeper pilot by request; no labels, closes, repairs, or merges were performed.

@tianmind-studio tianmind-studio force-pushed the codex/windows-prettier-eol branch 2 times, most recently from 5ea4602 to 9d61b5f Compare June 23, 2026 06:51

@Git-on-my-level Git-on-my-level left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the focused fix. This is a small, scoped repository-hygiene change under the Windows app: it aligns Git checkout EOL handling with the existing desktop/windows .editorconfig LF policy, avoids weakening Prettier, and the lint/format check is passing. I don’t see security, dependency, workflow, or product-direction concerns here.

@tianmind-studio tianmind-studio force-pushed the codex/windows-prettier-eol branch from 9d61b5f to b47cdd3 Compare June 29, 2026 02:45
@Git-on-my-level

Copy link
Copy Markdown
Collaborator

Thanks @tianmind-studio — verified this independently.

desktop/windows/.editorconfig already declares end_of_line = lf, but nothing enforces that at the git level today, so CRLF checkouts were drowning out real lint findings. This scoped desktop/windows/.gitattributes (* text=auto eol=lf) is the correct, standard fix: it keeps the rule local to the subtree (root files stay unaffected) rather than weakening Prettier with endOfLine: auto or changing repo-wide behavior.

  • Lint & Format Check: passing
  • Mergeable: clean
  • Scope: single 2-line file, no app-code/CI/dependency/auth surfaces touched

Nicely done.

— automated maintainer review (Omi PR monitor, glm-5.2)

@tianmind-studio tianmind-studio force-pushed the codex/windows-prettier-eol branch 2 times, most recently from e0cd3b8 to 713eb43 Compare July 3, 2026 05:11
@tianmind-studio tianmind-studio force-pushed the codex/windows-prettier-eol branch from 713eb43 to 6b6ec71 Compare July 3, 2026 10:23

@kodjima33 kodjima33 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Desktop chore: scoped .gitattributes to keep Windows app checkouts on LF.

@kodjima33 kodjima33 merged commit 18404e3 into BasedHardware:main Jul 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants