fix unnecessary null-aware operators in device.dart#8754
Merged
Conversation
connectedDevice is already null-checked before this closure runs, and BtDevice.name is non-nullable, so the ?. and ?? '' were both dead code flagged by the analyzer. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Git-on-my-level
approved these changes
Jul 1, 2026
Git-on-my-level
left a comment
Git-on-my-level
left a comment
Collaborator
There was a problem hiding this comment.
Clean fix. Verified that BtDevice.name is non-nullable (String name) and the onTap closure is guarded by provider.connectedDevice != null, so the !. assertions are safe and the previous ?. chains were correctly flagged as unnecessary by the analyzer. Lint & Format check passes. Thanks @krushnarout!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
connectedDevice?.name?.toLowerCase()andconnectedDevice?.typeinside theonTapclosure at device.dart triggered analyzer errors — the closure only runs whenprovider.connectedDevice != nullis already checked, so?.short-circuits tonulland never reaches.toLowerCase().BtDevice.nameis non-nullable, so?.toLowerCase() ?? ''was also dead code.Test plan
invalid_null_aware_operatorat device.dart:240 resolved🤖 Generated with Claude Code