Harden LLM gateway dev deploy guardrails#8766
Merged
Merged
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
There was a problem hiding this comment.
2 issues found across 7 files
Confidence score: 3/5
- In
backend/scripts/deploy-llm-gateway.sh, customCHART_DIR,VALUES_FILE, orRELEASE_NAMEcan leak intodeploy-backend-secrets.sh, so the backend-secrets step may render/deploy the wrong chart or values and misconfigure secrets in the target environment — isolate or explicitly reset gateway-specific overrides before invoking the secrets deploy script. - In
backend/scripts/deploy-backend-secrets.sh, force-sync appears to target an annotation name that can diverge whenexternalSecret.nameis customized, so Helm may report success but sync still fails and leaves deployment in a partially applied state — derive the ExternalSecret target from the configuredexternalSecret.name(or the rendered manifest) before merging.
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
2a477f9 to
c6fb64f
Compare
Collaborator
Author
|
Addressed the two Cubic review comments in
Local verification and pre-push passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
DRY_RUN=true ENVIRONMENT=dev GCP_PROJECT_ID=based-hardware-dev GKE_CLUSTER=dev-omi-gke REGION=us-central1 IMAGE_TAG=test backend/scripts/deploy-llm-gateway.shDRY_RUN=true ENVIRONMENT=prod GCP_PROJECT_ID=based-hardware GKE_CLUSTER=prod-omi-gke REGION=us-central1 IMAGE_TAG=test backend/scripts/deploy-llm-gateway.shexits 2 with the dev-only guardpython backend/scripts/validate-llm-gateway-env.pyfor dev and prod valuesgit diff --check origin/main...HEADgcr.io/based-hardware-dev/llm-gateway:c6fb64f, 1/1 pod readyNotes
.coordination/llm-gateway-rollout-plan.mdwith the prod enablement gate