[codex] Unify floating chat surface across notch and pill modes

[Git-on-my-level]

Summary

• unify the floating chat surface so non-notch displays keep the compact pill when collapsed but open into the same chat experience as notched displays
• remove the old separate floating agent window/view path and route pill-mode agent rows through the unified surface
• add guard coverage so non-notch expanded chat cannot drift back into the old bar chrome path

Validation

• xcrun swift test --package-path desktop/macos/Desktop --filter 'FloatingBarGeometryTests|AgentPillLifecycleTests'
• git diff --check
• launched forced non-notch bundle: /Applications/omi-force-no-notch.app with OMI_FORCE_NO_NOTCH=1, bridge 47931
• launched notched bundle: /Applications/omi-notch-chat.app, bridge 47932, verified floatingBarUsesNotchIsland: true

[cubic-dev-ai]

1 issue found across 12 files

Confidence score: 4/5

• In desktop/macos/Desktop/Sources/FloatingControlBar/FloatingControlBarView.swift, the early-return pill-mode agent-list path can skip clearing isHovering, which may leave legacy expanded hover chrome visibly stuck after mode switches; this is a user-facing polish regression rather than a core flow break—reset isHovering in that branch before merging to keep hover state transitions consistent.

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="desktop/macos/Desktop/Sources/FloatingControlBar/FloatingControlBarView.swift">

<violation number="1" location="desktop/macos/Desktop/Sources/FloatingControlBar/FloatingControlBarView.swift:750">
P2: Pill-mode hover can leave the legacy expanded hover chrome stuck on because the new early-return agent-list path never clears `isHovering`. Resetting `isHovering` in this branch keeps the UI consistent when switching between hover-expanded bar and pill agent rows.</violation>
</file>

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[cubic-dev-ai]

P2: Pill-mode hover can leave the legacy expanded hover chrome stuck on because the new early-return agent-list path never clears isHovering. Resetting isHovering in this branch keeps the UI consistent when switching between hover-expanded bar and pill agent rows.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At desktop/macos/Desktop/Sources/FloatingControlBar/FloatingControlBarView.swift, line 750:

<comment>Pill-mode hover can leave the legacy expanded hover chrome stuck on because the new early-return agent-list path never clears `isHovering`. Resetting `isHovering` in this branch keeps the UI consistent when switching between hover-expanded bar and pill agent rows.</comment>

<file context>
@@ -753,13 +743,31 @@ struct FloatingControlBarView: View {
+        // With subagents present, hovering the pill unfurls the agent rows —
+        // the same surface the notch shows on hover — instead of the legacy
+        // expanded bar. Moving the pointer away collapses back to the pill.
+        if !agentPills.pills.isEmpty, !state.showingAIConversation {
+            let barWindow = window as? FloatingControlBarWindow
+            if effectiveHover {
</file context>

Suggested change

	if !agentPills.pills.isEmpty, !state.showingAIConversation {
	let barWindow = window as? FloatingControlBarWindow
	if effectiveHover {
	barWindow?.setPillAgentListVisible(true)
	} else {
	barWindow?.schedulePillAgentListCollapse()
	}
	return
	}
	if !agentPills.pills.isEmpty, !state.showingAIConversation {
	withAnimation(.easeInOut(duration: 0.12)) {
	isHovering = false
	}
	let barWindow = window as? FloatingControlBarWindow
	if effectiveHover {
	barWindow?.setPillAgentListVisible(true)
	} else {
	barWindow?.schedulePillAgentListCollapse()
	}
	return
	}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1bd366bc75

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Preserve pill position before opening subagent chat

On non-notched displays with the draggable floating bar enabled, selecting one of these new in-window pill rows expands the same window via openAgentInChat without first recording the collapsed pill position. That leaves preChatCenter nil, so closeAIConversation() falls back to the expanded chat window's center and the compact pill reappears shifted down/centered under the 382px chat surface; the old separate AgentPillsWindow path did not resize the bar itself. Capture the pill's top-center before presenting the agent chat.

Useful? React with 👍 / 👎.