Skip to content

Add route policy baseline gate#9107

Merged
Git-on-my-level merged 1 commit into
mainfrom
codex/8959-route-policy-baseline-gate
Jul 6, 2026
Merged

Add route policy baseline gate#9107
Git-on-my-level merged 1 commit into
mainfrom
codex/8959-route-policy-baseline-gate

Conversation

@Git-on-my-level

@Git-on-my-level Git-on-my-level commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add a deterministic legacy missing-route baseline for the current backend-main route policy manifest gaps.
  • Add a strict route policy baseline gate that fails on newly missing manifest entries, stale baseline keys, and PR baseline growth relative to the target branch.
  • Keep the full route policy inventory check report-only while docs explain that new routes need real manifest entries instead of legacy-baseline additions.

Context

PR #8967 added the report-only inventory phase for #8959, but it intentionally left the manifest empty and the issue open. This PR is the next ratchet: it blocks new backend-main route policy gaps without inventing policy for the existing legacy surface.

Refs #8959

Review Notes

  • Consulted Oracle because this touches CI policy. Its must-fix recommendation was to prevent baseline creep by comparing PR baseline additions against the base branch; this PR implements that via --base-missing-baseline and the PR workflow fetch step.
  • This is metadata/tooling only; no runtime request handling changes.

Verification

  • .openapi-venv/bin/python -m pytest tests/unit/test_route_policy_inventory.py -q
  • scripts/openapi_runner.sh scripts/route_policy_inventory.py --manifest route_policy_manifest.yaml --enforce-missing-baseline --base-missing-baseline route_policy_legacy_missing_routes.txt
  • scripts/openapi_runner.sh scripts/route_policy_inventory.py --manifest route_policy_manifest.yaml --check --report-only --max-problem-lines 5
  • Pre-push hook passed, including backend preflight, focused route policy tests, OpenAPI contract check, workflow checks, and black --check.

Review in cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@Git-on-my-level Git-on-my-level merged commit 1a305b6 into main Jul 6, 2026
6 checks passed
@Git-on-my-level Git-on-my-level deleted the codex/8959-route-policy-baseline-gate branch July 6, 2026 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant