refactor(desktop): SPM library targets and Sources layout (closes #8848)#9134
Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Git-on-my-level
force-pushed
the
agent/m4-mba-cursor-composer/56290212
branch
2 times, most recently
from
717af8c to
6de79e8
Compare
Split OmiTheme, OmiSupport, and OmiWAL out of the monolithic executable, move onboarding files into Onboarding/, and add a Sources-root layout ratchet script plus AGENTS.md guidance. Closes #8848. Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: multica-agent <github@multica.ai>
Git-on-my-level
force-pushed
the
agent/m4-mba-cursor-composer/56290212
branch
from
6de79e8 to
a347034
Compare
Collaborator
Author
|
Monitor update for PR #9134:
Verification passed:
No unresolved review threads were present on the final re-scan. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Omi Computerexecutable:OmiTheme,OmiSupport(DesktopLocalProfile), andOmiWAL(WAL DTOs/models).Onboarding*.swiftfiles intoDesktop/Sources/Onboarding/, reducing root-level Sources clutter (103 → 77 files).scripts/check-sources-root-layout.pyand documents the no-new-root-Swift-files rule indesktop/macos/AGENTS.md.Follow-up (not in this PR)
Rewind/Core/still references main-app types (TaskActionItem,PowerMonitor, etc.) and needs a shared-models carve-out first..github/workflows/lint.yml(push was blocked here by missingworkflowOAuth scope).Test plan
xcrun swift build -c debug --package-path Desktoppython3 desktop/macos/scripts/check-sources-root-layout.pyCloses #8848
Made with Cursor