Skip to content

Require backend blessing for desktop promotion#9204

Closed
Git-on-my-level wants to merge 8 commits into
codex/python-backend-prod-blessing-gatefrom
codex/desktop-requires-backend-blessing
Closed

Require backend blessing for desktop promotion#9204
Git-on-my-level wants to merge 8 commits into
codex/python-backend-prod-blessing-gatefrom
codex/desktop-requires-backend-blessing

Conversation

@Git-on-my-level

@Git-on-my-level Git-on-my-level commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • add python_backend_sha to desktop prod promotion
  • require the named Python backend SHA to have a valid python-backend-bless- release
  • require the backend SHA to be an ancestor of the desktop release target unless the typed override is used
  • preserve the existing desktop release blessing and roll-forward checks

Stack

  1. Add release blessing surface registry #9201 — Release blessing surface registry
  2. Add Python backend blessing command #9202 — Python backend blessing command
  3. Gate backend prod deploys on blessing #9203 — Backend prod deploy blessing gate
  4. Require backend blessing for desktop promotion #9204 — this PR

Verification

  • python3 .github/scripts/check-desktop-prod-promotion-policy.py
  • python3 .github/scripts/test_check_desktop_release_promotion.py
  • python3 .github/scripts/test_check_python_backend_blessing.py
  • python3 .github/scripts/test_release_blessing.py
  • YAML parse check for .github/workflows/desktop_promote_prod.yml
  • pre-push hook passed for the full stack, including OpenAPI checks

krushnarout and others added 3 commits July 7, 2026 08:24
@krushnarout @claude
fix center mic icon in home chat bar circle
002e981 
The 42x42 Container had no alignment, so the FaIcon rendered at the
top-left of the white circle instead of its center. Add
alignment: Alignment.center (and make the icon const).

Verified: flutter analyze clean on the file; exercised on iPhone dev
build — mic icon now centered (screenshots in PR).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions
chore: consolidate changelog for v0.12.41
9545e8f
@omi-ci-bot
Update desktop changelog for v0.12.41 [skip ci] (#9199)
e51670f 
Auto-generated: consolidates unreleased changelog fragments into
v0.12.41 and regenerates CHANGELOG.json.
This was referenced Jul 7, 2026
Closed
Merged
Merged
cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Jul 7, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jul 7, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 920b1dd901

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/desktop_promote_prod.yml
@Git-on-my-level Git-on-my-level force-pushed the codex/desktop-requires-backend-blessing branch from 920b1dd to 12b6fc9 Compare July 7, 2026 07:33
@Git-on-my-level Git-on-my-level force-pushed the codex/python-backend-prod-blessing-gate branch from 6c20f0e to 70c69a7 Compare July 7, 2026 07:33
@Git-on-my-level Git-on-my-level force-pushed the codex/desktop-requires-backend-blessing branch from 12b6fc9 to 6c81b1d Compare July 7, 2026 09:36
@Git-on-my-level

Git-on-my-level commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator Author

Monitor follow-up for the backend-blessed desktop promotion PR:

  • Updated the promotion docs/runbook references so operators pass python_backend_sha=<40-char blessed python-backend SHA> when dispatching desktop_promote_prod.yml.
  • Resolved the review thread about the new promotion SHA input.

Verification passed:

  • python3 .github/scripts/check-desktop-prod-promotion-policy.py
  • python3 .github/scripts/test_check_desktop_release_promotion.py
  • python3 .github/scripts/test_check_python_backend_blessing.py
  • python3 .github/scripts/test_release_blessing.py
  • YAML parse check for .github/workflows/desktop_promote_prod.yml
  • GitHub checks after push: Backend unit suite and Public Developer API contract passed

kodjima33
kodjima33 approved these changes Jul 7, 2026
View reviewed changes

@kodjima33 kodjima33 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Require backend blessing for desktop promotion — approve-only; modifies prod promotion workflows, needs Nik.

@Git-on-my-level

Git-on-my-level commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator Author

Will wait for existing blessing infra to bake first

@Git-on-my-level Git-on-my-level marked this pull request as draft July 7, 2026 20:54
This was referenced Jul 10, 2026
Open
Open
@Git-on-my-level

Git-on-my-level commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator Author

Superseded by #9400.

Rebuilt on current main after #9380 (qualified beta → stable-candidate nomination → stable). The old override_unblessed / I-ACCEPT-UNBLESSED-PROD-RISK / blessed_sha desktop gate language is stale; the successor uses the #9380 audited break-glass path and requires python_backend_sha.

Closing this PR in favor of #9400.

@Git-on-my-level

Git-on-my-level commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator Author

Closing as superseded by #9400.

@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Hey @Git-on-my-level 👋

Thank you so much for taking the time to contribute to Omi! We truly appreciate you putting in the effort to submit this pull request.

After careful review, we've decided not to merge this particular PR. Please don't take this personally — we genuinely try to merge as many contributions as possible, but sometimes we have to make tough calls based on:

  • Project standards — Ensuring consistency across the codebase
  • User needs — Making sure changes align with what our users need
  • Code best practices — Maintaining code quality and maintainability
  • Project direction — Keeping aligned with our product principles and locked invariants

Before your next PR, please skim:

  • PRODUCT.md — product north star
  • Product invariants — locked rules (shared chat, memory tiers, agent control plane, integrations, brand)

If this was declined for direction or taste, maintainers should cite an invariant ID or open a proposed one — ask if that citation is missing.

Your contribution is still valuable to us, and we'd love to see you contribute again in the future! If you'd like feedback on how to improve this PR or want to discuss alternative approaches, please don't hesitate to reach out.

Thank you for being part of the Omi community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments
@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@kodjima33 kodjima33 kodjima33 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Git-on-my-level @kodjima33 @krushnarout