Remove BYOK step from desktop onboarding by Git-on-my-level · Pull Request #9309 · BasedHardware/omi

Git-on-my-level · 2026-07-09T05:11:29Z

Summary

Removes the optional Bring Your Own Keys onboarding step that confused casual users; Goal now goes straight to Tasks
Migrates mid-onboarding users who were on BYOK/Tasks onto the Tasks step
Removes the pill and bottom gradient behind the “This is your 2nd brain” graph label

BYOK remains available in Settings → Advanced and from the usage-limit paywall.

Test plan

Fresh onboarding: after Goal, next screen is Tasks (no API keys step)
Mid-flow users previously on BYOK or Tasks land on Tasks after update
Graph pane “This is your 2nd brain” label has no background/gradient
OnboardingFlowTests pass
BYOK still works from Settings → Advanced

Made with Cursor

Drop the optional API-keys screen that confused casual users, migrate mid-flow users onto Tasks, and remove the 2nd-brain label background. Co-authored-by: Cursor <cursoragent@cursor.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9de330c0b5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-07-09T05:17:11Z

+    if !hasRemovedBYOKStep, migratedStep > 17 {
+      migratedStep -= 1


Adjust BYOK removal for pending notification migration

When a profile still has onboardingNotificationPermissionStepRemoved=false and is paused on the old BYOK page, its persisted index is 18 because the removed notification-permission page was before BYOK. This new shift first maps 18→17, and then OnboardingView applies the pending notification removal (currentStep >= 8 → -1), so that user lands on Goal (16) instead of Tasks. Apply the notification-permission migration before this BYOK removal or account for that pending flag here.

Useful? React with 👍 / 👎.

cubic-dev-ai

All reported issues were addressed across 7 files

Confidence score: 5/5

Safe to merge after the addressed issues were fixed.

_{You’re at about 95% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.}

_{Reply with feedback, questions, or to request a fix.

Re-trigger cubic}

Fold notification-permission removal into migratedStep before BYOK removal so legacy BYOK resumes land on Tasks, and cover the changed onboarding files in harness-smoke. Co-authored-by: Cursor <cursoragent@cursor.com>

Git-on-my-level · 2026-07-09T05:37:40Z

Addressed review + CI:

Migration ordering — moved onboardingNotificationPermissionStepRemoved into OnboardingFlow.migratedStep() before BYOK removal, so a legacy BYOK index (18 with notifications still counted) lands on Tasks (17) instead of Goal (16). Added testMigrationRemovesBYOKAfterPendingNotificationPermissionRemoval.
E2E coverage CI — added OnboardingFlow.swift, OnboardingStepScaffold.swift, and OnboardingView.swift to harness-smoke.yaml covers.

OnboardingFlowTests: 7/7 passed locally.

Git-on-my-level · 2026-07-09T05:37:46Z

Addressed review + CI:

Migration ordering — moved onboardingNotificationPermissionStepRemoved into OnboardingFlow.migratedStep() before BYOK removal, so a legacy BYOK index (18 with notifications still counted) lands on Tasks (17) instead of Goal (16). Added testMigrationRemovesBYOKAfterPendingNotificationPermissionRemoval.
E2E coverage CI — added OnboardingFlow.swift, OnboardingStepScaffold.swift, and OnboardingView.swift to harness-smoke.yaml covers.

OnboardingFlowTests: 7/7 passed locally.

cubic-dev-ai

All reported issues were addressed across 4 files (changes from recent commits).

_{You’re at about 95% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.}

_{Reply with feedback, questions, or to request a fix.

Re-trigger cubic}

Match BYOK removal semantics: exact index 8 stays at Accessibility instead of sliding back to Microphone. Co-authored-by: Cursor <cursoragent@cursor.com>

Git-on-my-level · 2026-07-09T06:08:06Z

Follow-up on the latest cubic notes:

Notification-permission exact index — changed the folded migration from >= 8 to > 8, so users paused on the removed notification-permission step advance to Accessibility (8) instead of Microphone (7). Regression covered in testMigrationRemovesBYOKAfterPendingNotificationPermissionRemoval.
harness-smoke covers metadata — leaving the onboarding covers: entries in place. CI’s --strict e2e coverage gate requires changed Swift sources to be listed, and this file already covers other onboarding sources the smoke path doesn’t execute (OnboardingChatView, floating-bar/voice demos). A dedicated onboarding flow would be a separate follow-up; removing the entries would re-break Desktop Swift CI.

Keep harness-smoke honest about what it exercises, and satisfy the strict coverage gate with a manual onboarding-flow that targets Goal→Tasks after BYOK removal. Co-authored-by: Cursor <cursoragent@cursor.com>

Git-on-my-level · 2026-07-09T06:11:06Z

Follow-up on the remaining cubic note:

Removed OnboardingFlow / OnboardingStepScaffold / OnboardingView from harness-smoke covers
Added dedicated e2e/flows/onboarding-flow.yaml (tier: manual) that covers those files and documents Goal → Tasks (no BYOK) plus the 2nd-brain label check

desktop-flow-lint and check-e2e-flow-coverage.py --strict both pass for the changed onboarding sources.

Remove BYOK step from desktop onboarding.

9de330c

Drop the optional API-keys screen that confused casual users, migrate mid-flow users onto Tasks, and remove the 2nd-brain label background. Co-authored-by: Cursor <cursoragent@cursor.com>

chatgpt-codex-connector Bot reviewed Jul 9, 2026

View reviewed changes

cubic-dev-ai Bot reviewed Jul 9, 2026

View reviewed changes

Comment thread desktop/macos/Desktop/Sources/Onboarding/OnboardingFlow.swift

Fix BYOK migration ordering and e2e coverage.

af9a906

Fold notification-permission removal into migratedStep before BYOK removal so legacy BYOK resumes land on Tasks, and cover the changed onboarding files in harness-smoke. Co-authored-by: Cursor <cursoragent@cursor.com>

cubic-dev-ai Bot reviewed Jul 9, 2026

View reviewed changes

Comment thread desktop/macos/e2e/flows/harness-smoke.yaml Outdated

Comment thread desktop/macos/Desktop/Sources/Onboarding/OnboardingFlow.swift Outdated

Keep users on removed notification step advancing to Accessibility.

65f486c

Match BYOK removal semantics: exact index 8 stays at Accessibility instead of sliding back to Microphone. Co-authored-by: Cursor <cursoragent@cursor.com>

Move onboarding e2e covers into a dedicated flow.

d20273e

Keep harness-smoke honest about what it exercises, and satisfy the strict coverage gate with a manual onboarding-flow that targets Goal→Tasks after BYOK removal. Co-authored-by: Cursor <cursoragent@cursor.com>

Git-on-my-level merged commit aca796e into main Jul 9, 2026
20 checks passed

Git-on-my-level deleted the cursor/315f43b1 branch July 9, 2026 06:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove BYOK step from desktop onboarding#9309

Remove BYOK step from desktop onboarding#9309
Git-on-my-level merged 4 commits into
mainfrom
cursor/315f43b1

Git-on-my-level commented Jul 9, 2026 •

edited by cubic-dev-ai Bot

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Jul 9, 2026

Uh oh!

cubic-dev-ai Bot left a comment •

edited

Loading

Uh oh!

Uh oh!

Git-on-my-level commented Jul 9, 2026

Uh oh!

Git-on-my-level commented Jul 9, 2026

Uh oh!

cubic-dev-ai Bot left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Git-on-my-level commented Jul 9, 2026

Uh oh!

Git-on-my-level commented Jul 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		if !hasRemovedBYOKStep, migratedStep > 17 {
		migratedStep -= 1

Uh oh!

Conversation

Git-on-my-level commented Jul 9, 2026 • edited by cubic-dev-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jul 9, 2026

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Git-on-my-level commented Jul 9, 2026

Uh oh!

Git-on-my-level commented Jul 9, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Git-on-my-level commented Jul 9, 2026

Uh oh!

Git-on-my-level commented Jul 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Git-on-my-level commented Jul 9, 2026 •

edited by cubic-dev-ai Bot

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading