Fix mobile auth refresh 401 recovery loop - #9397
Merged
Merged
Conversation
Prevent authenticated requests from degrading to anonymous traffic, bind token refreshes to the originating Firebase UID, and terminate confirmed dead sessions exactly once. Clear user-scoped provider/cache state, cancel stale async work and conversation retries, route to localized reauthentication UI, and add a signed iOS refresh canary. Verification: cd app && flutter test --no-pub (704 passed); flutter gen-l10n (zero untranslated warnings); targeted dart analyze (no compile errors); git diff --check; independent agent review approved. UI limitation: no physical iOS device or simulator was available for the signed canary; the reauthentication path was exercised through its Flutter widget regression test.
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9375
This PR fixes the mobile auth-refresh failure that caused repeated 401 conversation requests and a misleading signed-in shell.
Verification:
cd app && flutter test --no-pub— 704 tests passed.flutter gen-l10n— zero untranslated-message warnings.The physical signed iOS canary was added but could not be run locally because no iOS device or simulator was available.