fix(ci): complete Windows pre-push launch path#9804
Open
tianmind-studio wants to merge 1 commit into
Conversation
Collaborator
|
Thanks for tightening the Windows pre-push path. I reviewed the diff and the shape looks good: the wrapper now invokes the extensionless Bash hook through the active Bash executable, the portability check is triggered when the wrapper changes, and the added tests cover both the wrapper contract and a real runner-to-Bash launch path. I’m not formally approving because this touches CI/pre-push workflow plumbing and the PR targets a stacked/non-default base branch, so it should still get human maintainer review before merge. No changes requested from this automation review. by AI on behalf of David — if you need David’s attention urgently, please @Git-on-my-level and escalate with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the native-Windows launch path in #9730:
preflight_runner.pybefore the extensionlessscripts/pre-pushpathkillpgsimulations construct that missing API on WindowsRoot cause and guard
After #9730 avoids the missing
signal.SIGHUP, Python 3.11 on Windows reachessubprocess.PopenbutCreateProcesscannot execute the extensionless Bash script directly. Binding the wrapper to its already-running$BASHpreserves POSIX behavior and gives Windows an executable entrypoint. The manifest-backed regression test keeps that argv contract attached to future wrapper edits.Verification
--waspre-push, not Bash.python .github/scripts/test_preflight_runner.py-> 11 tests OK on native Windowspython .github/scripts/test_run_checks.py-> 9 tests OKwindows-bash-launch-okgit pushreached and passed the portability/preflight/deployment-policy checks; the older fix(ci): make pre-push single-flight runner start on hosts without POSIX signals (#9724) #9730 base then stopped at its pre-existingbackend/.venv/bin/pythonrequirement.Product invariants: none.