Skip to content

feat move This Device memory filter into the filter sheet#9978

Merged
krushnarout merged 1 commit into
mainfrom
feat/move-this-device-filter-into-sheet
Jul 19, 2026
Merged

feat move This Device memory filter into the filter sheet#9978
krushnarout merged 1 commit into
mainfrom
feat/move-this-device-filter-into-sheet

Conversation

@krushnarout

@krushnarout krushnarout commented Jul 18, 2026

Copy link
Copy Markdown
Member

What

Moves the This Device memory filter chip out of the memories search row and into the filter bottom sheet (opened by the last icon on the search row). It now sits below the category options (All / System / Interesting / Manual), separated by a divider, and toggles without closing the sheet — matching the category options' behavior.

  • page.dart: removed the standalone FilterChip from the search row (and its shimmer placeholder).
  • memory_management_sheet.dart: added the This Device row to the sheet; extracted a shared _buildFilterOption row builder reused by the category options.
This Device filter inside the filter sheet

Product invariants affected

  • INV-MEM-1 — UI-only relocation of the This Device filter control; filtering semantics and memory-tier behavior are unchanged.

Verification

  • dart format --line-length 120 on both files (no changes).
  • flutter analyze on both files — only pre-existing info-level lints, no warnings or errors.
  • scripts/pr-preflight local lane passes with this body.

🤖 Generated with Claude Code

Review in cubic

Moves the This Device chip out of the memories search row and into the
filter bottom sheet (opened by the last icon on the search row), below
the category options and separated by a divider.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

@kodjima33 kodjima33 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mobile feature (This Device memory filter into filter sheet). Approve-only (feature).

@krushnarout
krushnarout merged commit 11bae04 into main Jul 19, 2026
23 of 26 checks passed
@krushnarout
krushnarout deleted the feat/move-this-device-filter-into-sheet branch July 19, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants