Skip to content

Implement plated einsum#692

Merged
eb8680 merged 108 commits into
staging-weightedfrom
jf-weighted-plated-einsum
Jul 20, 2026
Merged

Implement plated einsum#692
eb8680 merged 108 commits into
staging-weightedfrom
jf-weighted-plated-einsum

Conversation

@jfeser

@jfeser jfeser commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@jfeser
jfeser marked this pull request as ready for review July 16, 2026 15:27
@jfeser
jfeser requested a review from eb8680 July 17, 2026 02:27
Comment thread effectful/ops/monoid.py Outdated
return isinstance(owner, Monoid) and op is owner.delta


def _leaf_vars(expr: Any) -> set[Operation]:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than implement separate Term traversal logic (#682), this should post-process the result of fvsof to remove Operations with non-empty __signature__.parameters - that should be faster, safer and more general.

@eb8680
eb8680 merged commit a7d3cc7 into staging-weighted Jul 20, 2026
28 of 29 checks passed
@eb8680
eb8680 deleted the jf-weighted-plated-einsum branch July 20, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants