Add wave-1 read-path smoke perf gate#39
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 590e7d65e1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| func timeSearch(db *database.DB, query string, limit int) ([]database.DownloadedPhoto, int64, float64, error) { | ||
| start := time.Now() | ||
| photos, total, err := db.SearchPhotos(query, limit, 0) |
There was a problem hiding this comment.
Time the gallery search path instead
This smoke row exercises SearchPhotos, which backs the separate /api/search path, but the gallery UI sends its search text to fetchGalleryCatalog and the API then calls GetGalleryCatalog with GalleryCatalogFilters.Query. A regression in applyGalleryCatalogFilters—including reintroducing source_page LIKE or slow filtered facet recomputation under q—would still pass this new gate, so the wave-1 smoke does not verify the search read path changed by this commit; time GetGalleryCatalog(..., GalleryCatalogFilters{Query: query}) here instead.
Useful? React with 👍 / 👎.
Refs #22
What changed
ok-folio-etl smoke-read-pathsto time the post-backfill catalog page, source/category/artist/favorites facets, and search against the expected 50,338 downloaded rows and 1,953 artist facet rows.GetGalleryCatalog(..., GalleryCatalogFilters{Query: query}), matching/api/gallery/catalog?q=....categorycolumn via SQL grouping and added regression coverage proving stored category values drive the facet.source_page LIKEfrom gallery free-text search so URL-shaped text fields are not part of catalog/search text scans.Verification
git fetch origingit rebase origin/mainCurrent branch feat/folio-15-22-wave-1-50k-row-read-path-smokeperf-check is up to date../scripts/product-verifier.shnpm cicompleted;found 0 vulnerabilitiesnpm run buildcompleted viatsc -b && vite buildok-folio stack template check passedgo test ./...passedNotes
searchrow now times the gallery catalog query path rather than the standalone/api/searchhelper.Maestro-Backend: codex (0-end)
Greptile Summary
This PR adds a wave-1 read-path smoke gate for the folio catalog. The main changes are:
smoke-read-pathscommand for catalog, facet, favorite, and search timing.categorygrouping kept for category facets.Confidence Score: 5/5
The changes are focused on read-path smoke coverage, category facet behavior, and search scope, with repository verification reported as passing.
No code issues were identified in the reviewed changes, and the described checks cover the affected Go packages, dashboard build, stack template validation, and product verification.
What T-Rex did
Reviews (1): Last reviewed commit: "Time gallery catalog search in smoke gat..." | Re-trigger Greptile