Fix compilation warnings and type errors - #159
Merged
Merged
Conversation
ExAws.STS requires sweet_xml at compile time to enable XML parsing.
Without it, ex_aws_sts compiles with NO-OP parser that returns raw
XML strings instead of structured data.
Fixed by:
- Adding {:sweet_xml, "~> 0.7"} before ex_aws deps in mix.exs
- Ensuring proper compilation order for conditional parser loading
- Group function clauses together (submenu_open?/2, handle_event/3) - Remove File module alias conflict in process_file_job.ex - Fix Storage.retrieve_file/1 return type handling - Remove unused calculate_file_hash/1 in upload_controller.ex - Simplify calculate_local_free_space/1 by removing :disksup dependency - Apply mix format to all storage and component files
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Code Quality
Type System
Dependencies
Test Plan