Update dependencies to latest versions - #165
Merged
Merged
Conversation
Software Design improvements:
- Extract helper functions in settings.ex to reduce cyclomatic complexity
- Replace cond with if for simpler 2-branch logic in storage.ex
- Fix function grouping to follow Elixir conventions in settings.ex
- Simplify language URL generation by removing unreachable code path
Code Readability improvements:
- Add and use module aliases to reduce nested calls
- Rename is_valid_language? to valid_language? following naming conventions
- Fix alias ordering to follow Elixir style guide
Refactoring:
- Remove unused slug normalization functions in editor.ex
- Simplify handle_event("save_settings") by extracting handle_settings_saved/3
- Simplify error handling by extracting handle_settings_error/2
Cleanup:
- Remove dead code (4 unused functions)
- Consolidate admin languages parsing logic
- Improve settings params preparation
- Fix pattern matching coverage warning in language_switcher.ex
Updated packages: - igniter: 0.6.30 → 0.7.0 (no breaking changes) - phoenix_ecto: 4.6.5 → 4.7.0 - phoenix_html: 4.2.1 → 4.3.0 - phoenix_live_view: 1.1.12 → 1.1.17 - swoosh: 1.19.5 → 1.19.8 - tailwind: 0.4.0 → 0.4.1 - credo: 1.7.12 → 1.7.13 - dialyxir: 1.4.6 → 1.4.7 - ex_aws: 2.5.11 → 2.6.0 - usage_rules: 0.1.24 → 0.1.26 Additional transitive updates: - ecto: 3.13.2 → 3.13.5 - cowboy: 2.13.0 → 2.14.2 - phoenix_pubsub: 2.1.3 → 2.2.0 Not updated (intentionally): - gettext: 0.26.2 (1.0.2 available but keeping current) - ex_doc: 0.38.4 (0.39.1 available but keeping current) All tests pass, compilation successful.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated PhoenixKit dependencies to their latest versions, including igniter 0.7.0 which has no breaking changes.
Changes
Updated packages
Additional transitive updates
Not updated (intentionally)
Test plan